Skip to content

feat(ErrorBoundary): export ErrorBoundaryProps type#55974

Merged
afc163 merged 1 commit intoant-design:featurefrom
guoyunhe:export-error-boundary-props
Nov 28, 2025
Merged

feat(ErrorBoundary): export ErrorBoundaryProps type#55974
afc163 merged 1 commit intoant-design:featurefrom
guoyunhe:export-error-boundary-props

Conversation

@guoyunhe
Copy link
Contributor

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

导出组件对应的 Props 以保持一致性,方便开发者使用

📝 Change Log

Language Changelog
🇺🇸 English feat(ErrorBoundary): export ErrorBoundaryProps type
🇨🇳 Chinese feat(ErrorBoundary): 导出 ErrorBoundaryProps 类型

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

👁 Visual Regression Report for PR #55974 Passed ✅

🎯 Target branch: feature (18a8dad)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Preview is ready

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guoyunhe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the developer experience by making the ErrorBoundaryProps TypeScript type more accessible throughout the library. By explicitly exporting and re-exporting this type at various levels, it ensures consistency in type definitions and facilitates easier integration and type-checking for developers utilizing the ErrorBoundary component.

Highlights

  • Export ErrorBoundaryProps: The ErrorBoundaryProps interface, which defines the properties for the ErrorBoundary component, is now explicitly exported from its definition file (ErrorBoundary.tsx).
  • Re-export from alert index: The ErrorBoundaryProps type is now re-exported from components/alert/index.tsx, making it easily accessible when importing from the alert module.
  • Top-level export: The ErrorBoundaryProps type is also now exported from the main components/index.ts file, allowing for direct import from the root components module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

感谢您的贡献。这个 PR 导出了 ErrorBoundaryProps 类型,这与库中其他组件的做法保持了一致,也方便了开发者。代码变更看起来是正确的,并且遵循了项目的现有模式。做得很好!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 28, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 28, 2025

@afc163 afc163 merged commit 964e21f into ant-design:feature Nov 28, 2025
37 checks passed
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (18a8dad) to head (432167b).
⚠️ Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #55974   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          804       804           
  Lines        14812     14812           
  Branches      3913      3913           
=========================================
  Hits         14812     14812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guoyunhe guoyunhe deleted the export-error-boundary-props branch November 28, 2025 09:30
@codecov
Copy link

codecov bot commented Nov 28, 2025

Bundle Report

Changes will increase total bundle size by 262 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.89MB 262 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antd-with-locales.min.js 131 bytes 2.14MB 0.01%
antd.min.js 131 bytes 1.75MB 0.01%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants