feat: ConfigProvider support customize trigger for Tooltip/Popover/Popconfirm by aojunhao123 · Pull Request #55932 · ant-design/ant-design

aojunhao123 · 2025-11-26T14:08:23Z

🤔 This is a ...

🆕 New feature
⌨️ Accessibility improvement

🔗 Related Issues

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	ConfigProvider supports configuring trigger for Tooltip, Popover, and Popconfirm.
🇨🇳 Chinese	ConfigProvider 支持配置 Tooltip、Popover 和 Popconfirm 的 trigger 属性。

bolt-new-by-stackblitz · 2025-11-26T14:08:27Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-11-26T14:08:34Z

👁 Visual Regression Report for PR #55932 Passed ✅

🎯 Target branch: feature (964e21f)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

github-actions · 2025-11-26T14:08:35Z

coderabbitai · 2025-11-26T14:08:40Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2025-11-26T14:08:43Z

Summary of Changes

Hello @aojunhao123, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new capability to the ConfigProvider that allows for centralized management of the trigger property for Tooltip, Popover, and Popconfirm components. This enhancement provides greater control over how these UI elements are activated, particularly addressing accessibility concerns by facilitating global configuration of keyboard focus triggers.

Highlights

Global Trigger Configuration: The ConfigProvider component now supports configuring the trigger property for Tooltip, Popover, and Popconfirm components globally, allowing for consistent activation behavior across an application.
Enhanced Accessibility: This feature significantly improves accessibility by enabling developers to easily set focus as a trigger mechanism for these components, making them more navigable via keyboard.
Documentation Updates: New documentation and FAQ entries have been added in both English and Chinese, explaining how to utilize the new trigger configuration for improved keyboard accessibility, with practical code examples.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

pkg-pr-new · 2025-11-26T14:13:08Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@55932

commit: bd4feef

codecov · 2025-11-26T14:13:56Z

Bundle Report

Changes will increase total bundle size by 2.83kB (0.07%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.89MB	2.83kB (0.07%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js`	1.42kB	2.14MB	0.07%
`antd.min.js`	1.42kB	1.75MB	0.08%

Files in antd-with-locales.min.js:

./components/config-provider/context.ts → Total Size: 1.93kB

Files in antd.min.js:

./components/config-provider/context.ts → Total Size: 1.93kB

codecov · 2025-11-26T14:21:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6a1c837) to head (bd4feef).
⚠️ Report is 25 commits behind head on feature.

Additional details and impacted files

@@            Coverage Diff            @@
##           feature    #55932   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          803       804    +1     
  Lines        14893     14816   -77     
  Branches      3954      3914   -40     
=========================================
- Hits         14893     14816   -77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gemini-code-assist

Code Review

This pull request introduces a valuable feature by allowing Tooltip, Popover, and Popconfirm to have their trigger property configured globally via ConfigProvider. This is particularly useful for accessibility, as it enables setting focus triggers across the application. The implementation is solid, correctly propagating the context value and prioritizing component props. The documentation has been updated accordingly, including a helpful new FAQ section. I've found a couple of minor documentation inconsistencies that I've commented on. Overall, great work!

gemini-code-assist · 2025-11-26T14:27:05Z

components/config-provider/index.en-US.md

+| tooltip | Set Tooltip common props | { className?: string, style?: React.CSSProperties, classNames?:[Tooltip\["classNames"\]](/components/tooltip#semantic-dom), styles?: [Tooltip\["styles"\]](/components/tooltip#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, unique?: boolean, trigger?: [Tooltip\["trigger"\]](/components/tooltip#api) } | - |  |
+| popover | Set Popover common props | { className?: string, style?: React.CSSProperties, classNames?:[Popover\["classNames"\]](/components/popover#semantic-dom), styles?: [Popover\["styles"\]](/components/popover#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, trigger?: [Popover\["trigger"\]](/components/popover#api)} | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |
+| popconfirm | Set Popconfirm common props | { className?: string, style?: React.CSSProperties, classNames?:[Popconfirm\["classNames"\]](/components/popconfirm#semantic-dom), styles?: [Popconfirm\["styles"\]](/components/popconfirm#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, trigger?: [Popconfirm\["trigger"\]](/components/popconfirm#api)} | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |


There are a couple of issues in this table:

The version for the new trigger prop on tooltip is missing. It should be added for consistency.

The markdown links for popover and popconfirm have a syntax error (an extra } at the end of the link) which breaks them.

Suggested change

| tooltip | Set Tooltip common props | { className?: string, style?: React.CSSProperties, classNames?:[Tooltip\["classNames"\]](/components/tooltip#semantic-dom), styles?: [Tooltip\["styles"\]](/components/tooltip#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, unique?: boolean, trigger?: [Tooltip\["trigger"\]](/components/tooltip#api) } | - | |

| popover | Set Popover common props | { className?: string, style?: React.CSSProperties, classNames?:[Popover\["classNames"\]](/components/popover#semantic-dom), styles?: [Popover\["styles"\]](/components/popover#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, trigger?: [Popover\["trigger"\]](/components/popover#api)} | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |

| popconfirm | Set Popconfirm common props | { className?: string, style?: React.CSSProperties, classNames?:[Popconfirm\["classNames"\]](/components/popconfirm#semantic-dom), styles?: [Popconfirm\["styles"\]](/components/popconfirm#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, trigger?: [Popconfirm\["trigger"\]](/components/popconfirm#api)} | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |

| tooltip | Set Tooltip common props | { className?: string, style?: React.CSSProperties, classNames?:[Tooltip["classNames"]](/components/tooltip#semantic-dom), styles?: [Tooltip["styles"]](/components/tooltip#semantic-dom), arrow: boolean | { pointAtCenter: boolean }, unique?: boolean, trigger?: [Tooltip["trigger"]](/components/tooltip#api) } | - | trigger: 6.1.0 |

| popover | Set Popover common props | { className?: string, style?: React.CSSProperties, classNames?:[Popover["classNames"]](/components/popover#semantic-dom), styles?: [Popover["styles"]](/components/popover#semantic-dom), arrow: boolean | { pointAtCenter: boolean }, trigger?: [Popover["trigger"]](/components/popover#api) } | - | 5.23.0, arrow: 6.0.0, trigger: 6.1.0 |

| popconfirm | Set Popconfirm common props | { className?: string, style?: React.CSSProperties, classNames?:[Popconfirm["classNames"]](/components/popconfirm#semantic-dom), styles?: [Popconfirm["styles"]](/components/popconfirm#semantic-dom), arrow: boolean | { pointAtCenter: boolean }, trigger?: [Popconfirm["trigger"]](/components/popconfirm#api) } | - | 5.23.0, arrow: 6.0.0, trigger: 6.1.0 |

gemini-code-assist · 2025-11-26T14:27:05Z

components/config-provider/index.zh-CN.md

+| tooltip | 设置 Tooltip 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Tooltip\["classNames"\]](/components/tooltip-cn#semantic-dom), styles?: [Tooltip\["styles"\]](/components/tooltip-cn#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, unique?: boolean, trigger?: [Tooltip\["trigger"\]](/components/tooltip-cn#api)} | - | `trigger`: 6.1.0 |
+| popover | 设置 Popover 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Popover\["classNames"\]](/components/popover-cn#semantic-dom), styles?: [Popover\["styles"\]](/components/popover-cn#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, trigger?: [Popover\["trigger"\]](/components/popover-cn#api)} | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |
+| popconfirm | 设置 Popconfirm 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Popconfirm\["classNames"\]](/components/popconfirm-cn#semantic-dom), styles?: [Popconfirm\["styles"\]](/components/popconfirm-cn#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, trigger?: [Popconfirm\["trigger"\]](/components/popconfirm-cn#api)} | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |


There's a syntax error in the markdown table. The links for tooltip, popover, and popconfirm have an extra closing curly brace } which breaks the link. Please remove it.

Suggested change

| tooltip | 设置 Tooltip 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Tooltip\["classNames"\]](/components/tooltip-cn#semantic-dom), styles?: [Tooltip\["styles"\]](/components/tooltip-cn#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, unique?: boolean, trigger?: [Tooltip\["trigger"\]](/components/tooltip-cn#api)} | - | `trigger`: 6.1.0 |

| popover | 设置 Popover 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Popover\["classNames"\]](/components/popover-cn#semantic-dom), styles?: [Popover\["styles"\]](/components/popover-cn#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, trigger?: [Popover\["trigger"\]](/components/popover-cn#api)} | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |

| popconfirm | 设置 Popconfirm 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Popconfirm\["classNames"\]](/components/popconfirm-cn#semantic-dom), styles?: [Popconfirm\["styles"\]](/components/popconfirm-cn#semantic-dom), arrow: boolean \| { pointAtCenter: boolean }, trigger?: [Popconfirm\["trigger"\]](/components/popconfirm-cn#api)} | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |

| tooltip | 设置 Tooltip 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Tooltip["classNames"]](/components/tooltip-cn#semantic-dom), styles?: [Tooltip["styles"]](/components/tooltip-cn#semantic-dom), arrow: boolean | { pointAtCenter: boolean }, unique?: boolean, trigger?: [Tooltip["trigger"]](/components/tooltip-cn#api) } | - | `trigger`: 6.1.0 |

| popover | 设置 Popover 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Popover["classNames"]](/components/popover-cn#semantic-dom), styles?: [Popover["styles"]](/components/popover-cn#semantic-dom), arrow: boolean | { pointAtCenter: boolean }, trigger?: [Popover["trigger"]](/components/popover-cn#api) } | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |

| popconfirm | 设置 Popconfirm 组件的通用属性 | { className?: string, style?: React.CSSProperties, classNames?:[Popconfirm["classNames"]](/components/popconfirm-cn#semantic-dom), styles?: [Popconfirm["styles"]](/components/popconfirm-cn#semantic-dom), arrow: boolean | { pointAtCenter: boolean }, trigger?: [Popconfirm["trigger"]](/components/popconfirm-cn#api) } | - | 5.23.0, `arrow`: 6.0.0, `trigger`: 6.1.0 |

Signed-off-by: aojunhao123 <1844749591@qq.com>

socket-security · 2025-11-29T05:53:45Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@rc-component/tooltip@1.3.4 ⏵ 1.4.0				^-1

View full report

components/popconfirm/index.tsx

components/popover/index.tsx

gemini-code-assist bot reviewed Nov 26, 2025

View reviewed changes

aojunhao123 added 3 commits November 28, 2025 16:39

CP support customize trigger

54f6ba5

add faq

1e18587

update doc

079430c

aojunhao123 force-pushed the feat/20251126-a11y branch from cdd61fd to 079430c Compare November 28, 2025 08:39

aojunhao123 added 2 commits November 29, 2025 13:29

update deps

26b9fa6

Merge branch 'feature' into feat/20251126-a11y

a853d9f

Signed-off-by: aojunhao123 <1844749591@qq.com>

update snapshot

dd5580a

zombieJ reviewed Dec 1, 2025

View reviewed changes

components/popconfirm/index.tsx Outdated Show resolved Hide resolved

zombieJ reviewed Dec 1, 2025

View reviewed changes

components/popover/index.tsx Outdated Show resolved Hide resolved

aojunhao123 and others added 2 commits December 1, 2025 16:45

adjust logic

834a056

chore: adjust

bd4feef

zombieJ approved these changes Dec 1, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 1, 2025

zombieJ merged commit ca5817a into ant-design:feature Dec 1, 2025
38 checks passed

xrkffgg mentioned this pull request Dec 8, 2025

docs: add changelog 6.1.0 #56120

Merged

Uh oh!

Conversation

aojunhao123 commented Nov 26, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #55932 Passed ✅

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist bot commented Nov 26, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

pkg-pr-new bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading

coderabbitai bot commented Nov 26, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 26, 2025 •

edited

Loading

codecov bot commented Nov 26, 2025 •

edited

Loading

codecov bot commented Nov 26, 2025 •

edited

Loading

socket-security bot commented Nov 29, 2025 •

edited

Loading