Conversation
|
|
👁 Visual Regression Report for PR #55880 Failed ❌
Important There are 2 diffs found in this PR: 🔄
|
Summary of ChangesHello @zombieJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughSummary by CodeRabbit发布说明
✏️ Tip: You can customize this high-level summary in your review settings. Walkthrough更新了主题配置和样式选择器,并提升了两个 CSS-in-JS 相关依赖版本:将默认主题配置 Changes
Sequence Diagram(s)(本次变更为配置/样式与依赖版本调整,未引入新的控制流或运行时交互,故不提供序列图。) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 分钟
诗歌
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🧰 Additional context used📓 Path-based instructions (8)**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
components/**/style/*.ts📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
components/**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx,md}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx,css}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx,js}📄 CodeRabbit inference engine (AGENTS.md)
Files:
components/**/style/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
components/**/style/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (18)📓 Common learnings📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:30:28.374ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:30:28.374ZApplied to files:
📚 Learning: 2025-11-24T16:31:15.831ZApplied to files:
📚 Learning: 2025-11-24T16:30:28.374ZApplied to files:
📚 Learning: 2025-11-24T16:30:28.374ZApplied to files:
📚 Learning: 2025-11-24T16:30:28.374ZApplied to files:
📚 Learning: 2025-11-13T02:52:08.942ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request aims to change the default value of the hashed theme property to true, aligning it with the documentation. While this is a good correction, the current implementation might cause issues with snapshot tests, as a comment in the code indicates that hashing should be disabled in test environments for stability. I've suggested an improvement to make this behavior conditional on the environment, ensuring that hashing is enabled by default for users while preserving the stability of the test suite.
| token: defaultSeedToken, | ||
| override: { override: defaultSeedToken }, | ||
| hashed: false, | ||
| hashed: true, |
There was a problem hiding this comment.
This change aligns the default value of hashed with the documentation, which is great. However, it seems to overlook the comment on line 10 regarding snapshot stability in test environments: // To ensure snapshot stable. We disable hashed in test env..
Changing the default to true unconditionally will likely cause many snapshot tests to fail due to hashed class names.
To address this, I suggest making the value conditional on the environment. This will enable hashing by default for development and production, while keeping it disabled during tests to maintain snapshot stability.
| hashed: true, | |
| hashed: process.env.NODE_ENV !== 'test', |
Deploying ant-design-next with
|
| Latest commit: |
9f40076
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63ebf18c.ant-design-next.pages.dev |
| Branch Preview URL: | https://hashed.ant-design-next.pages.dev |
Deploying ant-design with
|
| Latest commit: |
9f40076
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5272acd.ant-design.pages.dev |
| Branch Preview URL: | https://hashed.ant-design.pages.dev |
size-limit report 📦
|
More templates
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #55880 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 803 803
Lines 14812 14812
Branches 3913 3913
=========================================
Hits 14812 14812 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| export const defaultConfig = { | ||
| token: defaultSeedToken, | ||
| override: { override: defaultSeedToken }, | ||
| hashed: false, |
There was a problem hiding this comment.
css car 后 token 挂载在 css var id 上,但是实际上现在看是不等价的
|
visual diff 挂了 |
Bundle ReportChanges will decrease total bundle size by 24.53kB (-0.63%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |







中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log
theme.hashedistruewhich will cause style conflict with multiple versions.theme.hashed为true,从而会导致多版本混用样式冲突的问题。