fix(Button): incorrect hover color for default solid button#55825
fix(Button): incorrect hover color for default solid button#55825afc163 merged 3 commits intoant-design:masterfrom
Conversation
|
|
👁 Visual Regression Report for PR #55825 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
|
|
Summary of ChangesHello @andriib-ship-it, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a visual bug affecting the default solid button component. The change ensures that the text color for these buttons is correctly applied during hover and active states, providing a consistent and intended user interface experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughSummary by CodeRabbit发布说明
✏️ Tip: You can customize this high-level summary in your review settings. Walkthrough修复按钮实心（solid）变体的样式生成逻辑：在 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where the hover and active text colors for a default solid button were incorrect. The change ensures the text color remains consistent across different states by using token.solidTextColor for all of them. The fix is correct and addresses the bug. I have one minor suggestion to improve code maintainability.
components/button/style/variant.ts
Outdated
| [getCssVar('text-color-hover')]: token.solidTextColor, | ||
| [getCssVar('text-color-active')]: token.solidTextColor, |
There was a problem hiding this comment.
While this is correct, to improve maintainability and reduce repetition, you could consider using the text-color CSS variable for the hover and active states. This ensures that if text-color is ever changed, the hover and active states will automatically update with it.
| [getCssVar('text-color-hover')]: token.solidTextColor, | |
| [getCssVar('text-color-active')]: token.solidTextColor, | |
| [getCssVar('text-color-hover')]: `var(${getCssVar('text-color')})`, | |
| [getCssVar('text-color-active')]: `var(${getCssVar('text-color')})`, |
More templates
commit: |
Bundle ReportChanges will increase total bundle size by 202 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #55825 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 803 803
Lines 14804 14804
Branches 3913 3913
=========================================
Hits 14804 14804 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log