chore: remove unstable api for React 19 compitable by li-jia-nan · Pull Request #55274 · ant-design/ant-design

li-jia-nan · 2025-10-11T21:05:13Z

Language	Changelog
🇺🇸 English	v6 本身支持 React 19，无需兼容
🇨🇳 Chinese	v6 本身支持 React 19，无需兼容

bolt-new-by-stackblitz · 2025-10-11T21:05:16Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2025-10-11T21:05:24Z

github-actions · 2025-10-11T21:05:25Z

👁 Visual Regression Report for PR #55274 Passed ✅

🎯 Target branch: next (9fdba0a)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

coderabbitai · 2025-10-11T21:05:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch rm-unstableSetRender-v6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2025-10-11T21:05:34Z

Summary of Changes

Hello @li-jia-nan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the rendering mechanism by removing a temporary, unstable API (unstableSetRender) that was introduced for React 19 compatibility. The changes reflect a move towards a more stable and integrated rendering solution, leveraging @rc-component/util/lib/React/render directly. This cleanup simplifies the codebase, removes deprecated interfaces, and ensures that components are using the recommended rendering approach for future React versions.

Highlights

Removal of unstableSetRender API: The unstableSetRender API, previously used for React 19 compatibility, has been completely removed. This includes its definition, exports, and all direct usages within the codebase.
Migration to @rc-component/util/lib/React/render: Components like WaveEffect, message, modal, and notification have been updated to directly utilize the render and unmount utilities from @rc-component/util/lib/React/render for their rendering needs, replacing the deprecated unstableSetRender.
Cleanup of related files: Associated test files (unstable.test.ts) and documentation (v5-for-19.en-US.md, v5-for-19.zh-CN.md) related to the unstableSetRender API and React 19 compatibility workarounds have been removed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly removes the deprecated unstableSetRender API, which was a temporary compatibility layer for React 19. The code is updated to use render and unmount from @rc-component/util directly, which simplifies the implementation. In components/modal/confirm.tsx, the local render function was also helpfully renamed to renderDialog to avoid shadowing the newly imported render function. The related tests, snapshots, and documentation have also been cleaned up accordingly.

I've found one critical issue in components/modal/confirm.tsx where the unmount function is called without the required container argument, which will cause an error. I've left a specific comment with a suggested fix. Besides that, the changes look good.

components/modal/confirm.tsx

github-actions · 2025-10-11T21:08:20Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	497.03 KB (+111 B 🔺)
`dist/antd-with-locales.min.js`	589.65 KB (-352 B 🔽)

cloudflare-workers-and-pages · 2025-10-11T21:09:39Z

Deploying ant-design-next with Cloudflare Pages

Latest commit:	`a02f91c`
Status:	✅ Deploy successful!
Preview URL:	https://9d80626b.ant-design-next.pages.dev
Branch Preview URL:	https://rm-unstablesetrender-v6.ant-design-next.pages.dev

View logs

cloudflare-workers-and-pages · 2025-10-11T21:10:23Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`a02f91c`
Status:	✅ Deploy successful!
Preview URL:	https://68c4060f.ant-design.pages.dev
Branch Preview URL:	https://rm-unstablesetrender-v6.ant-design.pages.dev

View logs

pkg-pr-new · 2025-10-11T21:24:23Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@55274

commit: a02f91c

codecov · 2025-10-11T21:30:18Z

Bundle Report

Changes will decrease total bundle size by 2.56kB (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	11.82MB	-2.56kB (-0.02%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.js`	-1.28kB	6.22MB	-0.02%
`antd.js`	-1.28kB	5.6MB	-0.02%

codecov · 2025-10-11T21:36:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d8d266b) to head (a02f91c).
⚠️ Report is 2 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff            @@
##              next    #55274   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          798       797    -1     
  Lines        14771     14752   -19     
  Branches      3897      3896    -1     
=========================================
- Hits         14771     14752   -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

li-jia-nan · 2025-10-12T00:15:16Z

官网挂了，需要等等这个：

chore: upgrade to React 19 antd-token-previewer#220

socket-security · 2025-10-13T14:16:32Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	clsx@2.1.1
	throttle-debounce@5.0.2
	scroll-into-view-if-needed@3.1.0
	adm-zip@0.5.16
	react@19.2.0
	ali-oss@6.23.0
	dayjs@1.11.18
	antd-img-crop@4.27.0
	react-dom@19.2.0

View full report

chore: remove unstable api for React 19 compitable

d70ee53

gemini-code-assist bot reviewed Oct 11, 2025

View reviewed changes

components/modal/confirm.tsx Outdated Show resolved Hide resolved

li-jia-nan added 2 commits October 12, 2025 05:20

update

4f94396

update

f8fc43e

update

834d4de

Merge branch 'next' into rm-unstableSetRender-v6

e9e856f

li-jia-nan requested a review from zombieJ October 12, 2025 01:05

li-jia-nan assigned MadCcc Oct 12, 2025

li-jia-nan requested a review from MadCcc October 12, 2025 01:05

li-jia-nan unassigned MadCcc Oct 12, 2025

Merge branch 'next' into rm-unstableSetRender-v6

b776e18

zombieJ previously approved these changes Oct 13, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 13, 2025

li-jia-nan added 2 commits October 13, 2025 17:54

Merge branch 'next' into rm-unstableSetRender-v6

065c4b0

update antd-token-previewer

848a68c

li-jia-nan dismissed zombieJ’s stale review via 848a68c October 13, 2025 09:57

li-jia-nan added 2 commits October 13, 2025 19:34

update

ede17a6

update

a02f91c

li-jia-nan requested a review from zombieJ October 13, 2025 14:23

thinkasany approved these changes Oct 13, 2025

View reviewed changes

li-jia-nan merged commit 01c0321 into next Oct 13, 2025
45 checks passed

li-jia-nan deleted the rm-unstableSetRender-v6 branch October 13, 2025 15:14

zombieJ mentioned this pull request Nov 4, 2025

docs: changelog of 6.0.0-alpha.4 #55604

Merged

17 tasks

dosubot bot mentioned this pull request Nov 25, 2025

[v6] UMD build does not work with react 18 (only works with 19) #55889

Open

Uh oh!

Conversation

li-jia-nan commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bolt-new-by-stackblitz bot commented Oct 11, 2025

Uh oh!

github-actions bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Visual Regression Report for PR #55274 Passed ✅

Uh oh!

coderabbitai bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist bot commented Oct 11, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

cloudflare-workers-and-pages bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design-next with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ant-design with Cloudflare Pages

Uh oh!

pkg-pr-new bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

li-jia-nan commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

li-jia-nan commented Oct 11, 2025 •

edited

Loading

github-actions bot commented Oct 11, 2025 •

edited

Loading

github-actions bot commented Oct 11, 2025 •

edited

Loading

coderabbitai bot commented Oct 11, 2025 •

edited

Loading

github-actions bot commented Oct 11, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 11, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 11, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 11, 2025 •

edited

Loading

codecov bot commented Oct 11, 2025 •

edited

Loading

codecov bot commented Oct 11, 2025 •

edited

Loading

li-jia-nan commented Oct 12, 2025 •

edited

Loading