Skip to content

feat(date-picker/time-picker): add previewValue option#55258

Merged
thinkasany merged 6 commits intoant-design:nextfrom
meet-student:feat-picker
Oct 10, 2025
Merged

feat(date-picker/time-picker): add previewValue option#55258
thinkasany merged 6 commits intoant-design:nextfrom
meet-student:feat-picker

Conversation

@meet-student
Copy link
Member

@meet-student meet-student commented Oct 10, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English add previewValue option
🇨🇳 Chinese add previewValue option

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Preview is ready

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

👁 Visual Regression Report for PR #55258 Passed ✅

🎯 Target branch: next (cd170fc)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @meet-student, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the DatePicker and TimePicker components by adding a previewValue option. This new feature provides users with more control over the interactive experience, specifically allowing them to enable or disable the temporary display of hovered date or time selections within the input field. The change includes comprehensive documentation updates and a demo to illustrate its usage.

Highlights

  • New previewValue Prop: Introduced a new previewValue prop for both DatePicker and TimePicker components.
  • Hover Behavior Control: This prop allows control over whether the input field temporarily displays the value of a hovered date or time option. By default, this behavior is active (hover), but it can be disabled by setting previewValue={false}.
  • Documentation Updates: The official documentation for DatePicker and TimePicker has been updated in both English and Chinese to reflect the new previewValue prop, including its description, type, default value, and version availability.
  • Demo Integration: A demo file for DatePicker (filled-debug.tsx) has been updated to include an example of previewValue={false}, demonstrating how to disable the hover preview.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new previewValue option for the DatePicker and TimePicker components. The changes primarily involve updating documentation and adding a demo case. I've found a few minor issues in the documentation files, including incorrect descriptions and inconsistent property ordering. My review comments provide specific suggestions to address these points.

meet-student and others added 3 commits October 10, 2025 18:01
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: 遇见同学 <1875694521@qq.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: 遇见同学 <1875694521@qq.com>
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 10, 2025

Signed-off-by: 遇见同学 <1875694521@qq.com>
Signed-off-by: 遇见同学 <1875694521@qq.com>
@codecov
Copy link

codecov bot commented Oct 10, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b16a5e) to head (0524aab).
⚠️ Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next    #55258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          798       798           
  Lines        14762     14762           
  Branches      3894      3894           
=========================================
  Hits         14762     14762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 10, 2025
@thinkasany thinkasany merged commit 195d50b into ant-design:next Oct 10, 2025
39 checks passed
@meet-student meet-student deleted the feat-picker branch October 10, 2025 13:01
@zombieJ zombieJ mentioned this pull request Nov 4, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants