feat(Switch): support classNames and styles for component and ConfigProvider#52849
Merged
thinkasany merged 3 commits intonextfrom Feb 17, 2025
Merged
feat(Switch): support classNames and styles for component and ConfigProvider#52849thinkasany merged 3 commits intonextfrom
classNames and styles for component and ConfigProvider#52849thinkasany merged 3 commits intonextfrom
Conversation
|
|
Contributor
|
|
Contributor
👁 Visual Regression Report for PR #52849 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 96 diffs found in this PR: 🔄
|
WalkthroughThis pull request introduces a new feature to the ConfigProvider component, allowing it to support custom class names and styles for the Switch component. This enhancement provides developers with more flexibility in styling the Switch component according to their needs. Changes
|
Closed
Contributor
size-limit report 📦
|
More templates
commit: |
Bundle ReportChanges will decrease total bundle size by 7.9MB (-67.8%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antd.min-array-pushAssets Changed:
Files in
Files in
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/rc-switch@4.1.0 |
Deploying ant-design with
|
| Latest commit: |
86c7686
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a90252a5.ant-design.pages.dev |
| Branch Preview URL: | https://cp-switch.ant-design.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #52849 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 765 765
Lines 13799 13799
Branches 3617 3617
=========================================
Hits 13799 13799 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Feb 17, 2025
components/switch/demo/_semantic.tsx
Outdated
| { name: 'content', desc: locale.content, version: '6.0.0' }, | ||
| ]} | ||
| > | ||
| <Switch checkedChildren="on" unCheckedChildren="off" defaultChecked /> |
Member
There was a problem hiding this comment.
要微调一下，现在这个在 unchecked 下会很奇怪。我本来是想看看 unchecked 时对应的位置看到的是这个：
zombieJ
approved these changes
Feb 17, 2025
classNames and styles for component and ConfigProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
📝 Change Log