refactor: Breadcrumb separator use li instead span#40887
Merged
afc163 merged 11 commits intoant-design:featurefrom Feb 24, 2023
Merged
refactor: Breadcrumb separator use li instead span#40887afc163 merged 11 commits intoant-design:featurefrom
li instead span#40887afc163 merged 11 commits intoant-design:featurefrom
Conversation
Contributor
|
|
afc163
reviewed
Feb 23, 2023
| {separator && ( | ||
| <li> | ||
| <span className={`${prefixCls}-separator`}>{separator}</span>{' '} | ||
| </li> |
Member
There was a problem hiding this comment.
内部也是不是直接用 Breadcrumb.Separator 实现？
Member
|
dom 结构变化，发到 feature 分支 |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## feature #40887 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 608 608
Lines 10340 10343 +3
Branches 2803 2804 +1
=========================================
+ Hits 10340 10343 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
ok |
72035ed to
b91dd0a
Compare
b91dd0a to
727fa7b
Compare
afc163
reviewed
Feb 24, 2023
| </li> | ||
| <> | ||
| <li>{link}</li> | ||
| {separator && <BreadcrumbSeparator>{children}</BreadcrumbSeparator>} |
Member
There was a problem hiding this comment.
Suggested change
| {separator && <BreadcrumbSeparator>{children}</BreadcrumbSeparator>} | |
| {separator && <BreadcrumbSeparator>{separator}</BreadcrumbSeparator>} |
Member
|
PR 上的 changelog 里写一下对用户的可能影响。 |
Member
|
类似 https://4x.ant.design/changelog-cn#4.3.0 里 tabs 这个写法。 |
Contributor
Author
done |
afc163
approved these changes
Feb 24, 2023
li instead span
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
#40867 (comment)
📝 Changelog
spaninultolito make the DOM structure more standardized. Please pay attention to the problems of missing overlay styles and element acquisition☑️ Self-Check before Merge