Skip to content

Adding functionality to force exit Fluent#1674

Merged
raph-luc merged 19 commits intomainfrom
feat/execute_cleanup_script
Jun 15, 2023
Merged

Adding functionality to force exit Fluent#1674
raph-luc merged 19 commits intomainfrom
feat/execute_cleanup_script

Conversation

@raph-luc
Copy link
Copy Markdown
Member

@raph-luc raph-luc commented Jun 8, 2023 •
edited
Loading

  • Inside fluent_connection.FluentConnection:
    Changed exit() image
    Added force_exit() and force_exit_container() image
  • New frozen dataclass:
    connection_propertiesimage
  • Simplified environment definition in GitHub actions YML files and made it so that GitHub runners always force exit in case normal exit fails. This is a potential fix for issues we were having with test runners randomly running out of memory due to the amount of zombie Fluent sessions - together with the WIP addition of the pyfluent watchdog process, and Fluent v241 auto exit on disconnect, should eliminate any possibility of these issues happening again in the future
  • New test_fluent_freeze_kill() and test_fluent_connection_properties()

@raph-luc raph-luc linked an issue Jun 8, 2023 that may be closed by this pull request
Execute cleanup script from pyfluent #1515
Closed
@raph-luc raph-luc mentioned this pull request Jun 8, 2023
Closed
@lagacep-ans
Copy link
Copy Markdown
Contributor

lagacep-ans commented Jun 8, 2023

Possibly rename kill_() functions to terminate_() , other suggestions for terminology?

@raph-luc raph-luc requested a review from lagacep-ans June 8, 2023 20:49
@raph-luc raph-luc marked this pull request as ready for review June 8, 2023 20:51
lagacep-ans
lagacep-ans reviewed Jun 8, 2023
View reviewed changes
mkundu1
mkundu1 reviewed Jun 8, 2023
View reviewed changes
mkundu1
mkundu1 reviewed Jun 8, 2023
View reviewed changes
mkundu1
mkundu1 reviewed Jun 8, 2023
View reviewed changes
mkundu1
mkundu1 reviewed Jun 8, 2023
View reviewed changes
@raph-luc raph-luc force-pushed the feat/execute_cleanup_script branch from 83b0f14 to 977d110 Compare June 9, 2023 18:08
mkundu1
mkundu1 reviewed Jun 9, 2023
View reviewed changes
@raph-luc raph-luc mentioned this pull request Jun 9, 2023
Closed
@raph-luc raph-luc requested review from lagacep-ans and mkundu1 June 9, 2023 20:59
mkundu1
mkundu1 reviewed Jun 12, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Jun 13, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Jun 13, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Jun 13, 2023
View reviewed changes
@raph-luc raph-luc linked an issue Jun 13, 2023 that may be closed by this pull request
test_server_exits_when_session_goes_out_of_scope failure #1678
Closed
@raph-luc raph-luc requested a review from mkundu1 June 13, 2023 20:00
@raph-luc
Copy link
Copy Markdown
Member Author

raph-luc commented Jun 14, 2023 •
edited
Loading

Waiting for #1671

edit: nvm, work in progress, will figure out conflicts on that PR

@raph-luc raph-luc merged commit 97d853c into main Jun 15, 2023
@raph-luc raph-luc deleted the feat/execute_cleanup_script branch June 15, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@lagacep-ans lagacep-ans lagacep-ans approved these changes

@hpohekar hpohekar hpohekar approved these changes

@prmukherj prmukherj prmukherj approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_server_exits_when_session_goes_out_of_scope failure Execute cleanup script from pyfluent

6 participants

@raph-luc @lagacep-ans @seanpearsonuk @mkundu1 @hpohekar @prmukherj