Merged
Conversation
raph-luc
reviewed
Jun 14, 2023
raph-luc
reviewed
Jun 15, 2023
mkundu1
reviewed
Jun 15, 2023
Collaborator
Great point, @raph-luc |
Co-authored-by: Sean Pearson <93727996+seanpearsonuk@users.noreply.github.com>
for more information, see https://pre-commit.ci
mkundu1
approved these changes
Jun 16, 2023
seanpearsonuk
approved these changes
Jun 16, 2023
raph-luc
approved these changes
Jun 16, 2023
raph-luc
reviewed
Jun 16, 2023
…/pyansys/pyfluent into maint/restruct_fluent_connection Pulled remote changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
svar_data
should be added only to solver session classes
id
identifies a session, should be part of the base session
get_current_fluent_mode
not needed, can be a direct API call from the launcher code
start_transcript
stop_transcript
now completely redundant due to transcript.start(), transcript.stop() which are the tested methods
also, we can update the docstring in launcher.py accordingly
start_journal
stop_journal
these are general-purpose session methods; add to session base class
check_health
checks the health of the connection. Retain in fluent_connection.py
get_fluent_version
add to base session
exit
belongs in fluent_connection.py