fix: check proper import and version variable#276
Merged
Conversation
Contributor
Author
|
@jorgepiloto and @RobPasMue right now... |
RobPasMue
requested changes
Jul 5, 2023
Member
|
I saw this issue some weeks ago, yeah... Thanks for opening the PR @germa89! |
raph-luc
reviewed
Jul 5, 2023
raph-luc
reviewed
Jul 5, 2023
Co-authored-by: Raphael Luciano <raphael.luciano@ansys.com>
RobPasMue
added a commit
that referenced
this pull request
Jul 5, 2023
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: Raphael Luciano <raphael.luciano@ansys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of
$()if there is an error while importing the library, the exception/error is hidden because it does not affect the parent process.With this PR, we check that the variable has ben properly created which means that the package can be imported properly.
Closes #275