feat: improve scenario selection and filtering for large collection trees#4613
Merged
feat: improve scenario selection and filtering for large collection trees#4613
Conversation
Replace plain string equality checks with fnmatch pattern matching so that -e can accept glob patterns like 'appliance_vlans/*' or '*/merged' in addition to exact scenario names. Co-authored-by: Cursor <cursoragent@cursor.com>
When -s receives a wildcard pattern like "camera_*" and the base MOLECULE_GLOB uses ** (recursive), append **/molecule.yml instead of just molecule.yml so scenarios at any nesting depth are discovered. Co-authored-by: Cursor <cursoragent@cursor.com>
Change MOLECULE_COLLECTION_GLOB from */molecule.yml to **/molecule.yml so nested scenarios are discovered automatically without requiring users to manually set MOLECULE_GLOB. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
for more information, see https://pre-commit.ci
…tection
- Use exact-match short-circuit before fnmatchcase to protect scenario
names containing literal glob characters
- Use wcmatch glob.is_magic with BRACE flag for wildcard detection so
brace expansion patterns like {camera,router}_* are recognized
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raksrh
approved these changes
Feb 24, 2026
rija
added a commit
to rmenage/ansible-role-hardened-docker
that referenced
this pull request
Mar 3, 2026
This MR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [molecule](https://github.com/ansible-community/molecule) ([changelog](https://github.com/ansible-community/molecule/releases)) | `>=25.0.0,<26.0.0` → `>=26.2.0,<26.3.0` |  |  | --- ### Release Notes <details> <summary>ansible-community/molecule (molecule)</summary> ### [`v26.2.0`](https://github.com/ansible/molecule/releases/tag/v26.2.0) [Compare Source](ansible/molecule@v25.12.0...v26.2.0) #### Features - feat: improve scenario selection and filtering for large collection trees ([#​4613](ansible/molecule#4613)) [@​cidrblock](https://github.com/cidrblock) - feat: support nested scenario directories in collection mode ([#​4611](ansible/molecule#4611)) [@​cidrblock](https://github.com/cidrblock) #### Fixes - fix: remove use of click-help-colors ([#​4569](ansible/molecule#4569)) [@​ssbarnea](https://github.com/ssbarnea) - fix: validate .git directories in find\_vcs\_root() ([#​4610](ansible/molecule#4610)) [@​skeetmtp](https://github.com/skeetmtp) - fix: handle missing molecule\_yml\_date\_modified key in state ([#​4606](ansible/molecule#4606)) [@​dmzoneill](https://github.com/dmzoneill) - Add execution flow documentation ([#​4589](ansible/molecule#4589)) [@​Qalthos](https://github.com/Qalthos) - Modify contact links in issue template config ([#​4586](ansible/molecule#4586)) [@​alisonlhart](https://github.com/alisonlhart) #### Maintenance - chore(deps): update all dependencies ([#​4612](ansible/molecule#4612)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore: replace pre-commit with prek ([#​4614](ansible/molecule#4614)) [@​ssbarnea](https://github.com/ssbarnea) - chore: use tox>=4.46.0 during testing ([#​4615](ansible/molecule#4615)) [@​ssbarnea](https://github.com/ssbarnea) - chore(deps): update pep621 ([#​4609](ansible/molecule#4609)) @​[renovate\[bot\]](https://github.com/apps/renovate) - Bump cryptography from 46.0.4 to 46.0.5 ([#​4604](ansible/molecule#4604)) @​[dependabot\[bot\]](https://github.com/apps/dependabot) - Bump pillow from 12.1.0 to 12.1.1 ([#​4605](ansible/molecule#4605)) @​[dependabot\[bot\]](https://github.com/apps/dependabot) - chore(deps): update all dependencies ([#​4608](ansible/molecule#4608)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4603](ansible/molecule#4603)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4599](ansible/molecule#4599)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update dependencies \[security] ([#​4601](ansible/molecule#4601)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4598](ansible/molecule#4598)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4595](ansible/molecule#4595)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4594](ansible/molecule#4594)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4593](ansible/molecule#4593)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4592](ansible/molecule#4592)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4591](ansible/molecule#4591)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4590](ansible/molecule#4590)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore(deps): update all dependencies ([#​4587](ansible/molecule#4587)) @​[renovate\[bot\]](https://github.com/apps/renovate) - chore: adopt pytest>=9.0.0 config ([#​4583](ansible/molecule#4583)) [@​Qalthos](https://github.com/Qalthos) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45OS4wIiwidXBkYXRlZEluVmVyIjoiNDIuOTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Refs: rmenage/ansible-role-hardened-docker!23 See-also:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Collections with hundreds of nested scenarios expose several pain points in Molecule's scenario selection and filtering:
MOLECULE_COLLECTION_GLOBdefaults to*/molecule.yml(flat), so nested scenarios aren't discovered unless users manually setMOLECULE_GLOBto a recursive pattern.-swildcards don't recurse —-s "camera_*"with a recursiveMOLECULE_GLOBproducescamera_*/molecule.ymlinstead ofcamera_*/**/molecule.yml, missing scenarios nested under matching directories.-eonly matches exact names — there's no way to exclude a group of scenarios by pattern (e.g.,-e "appliance_vlans/*"), forcing users to list every scenario name individually.All three issues stem from the same root cause: Molecule's scenario selection was designed for flat directory layouts and doesn't scale to deeply nested collection trees.
Solution
Three targeted changes, all in
src/molecule/command/base.pyandsrc/molecule/constants.py:1. Recursive default collection glob
Change
MOLECULE_COLLECTION_GLOBfromextensions/molecule/*/molecule.ymltoextensions/molecule/**/molecule.yml. This is a strict superset —**matches everything*matches plus nested directories — so existing flat layouts are unaffected.2. Recursive wildcard targeting with
-sWhen
-sreceives a wildcard pattern (e.g.,camera_*) and the base glob uses**, append**/molecule.ymlinstead of justmolecule.ymlso scenarios at any nesting depth are discovered.3. Glob-aware
-e/--excludefilteringReplace plain
not inchecks withfnmatchpattern matching via a new_is_excluded()helper, so-e "appliance_vlans/*"or-e "*/merged"exclude entire groups of scenarios.Changes
src/molecule/constants.py:MOLECULE_COLLECTION_GLOBuses**instead of*src/molecule/command/base.py:_is_excluded()helper usingfnmatch.fnmatch_is_excluded_resolve_scenario_globappends**/molecule.ymlfor wildcard + recursive glob combinationstests/unit/command/test_base.py: 9 parameterized test cases for_is_excludedtests/unit/test_nested_scenarios.py: Updated assertions for new default glob; 2 new recursive wildcard test casesTest plan
pytest tests/unit/test_nested_scenarios.py— 31 passedpytest tests/unit/command/test_base.py::test_is_excluded— 9 passedtox -e lint— clean