add tolerations/nodeselector to migration job template (fixes #1774)#1804
Conversation
|
@ranvit Is there a reason why My thinking here is that specifying The k8s db migration job uses the task container, and previously this was running in the task container, so using Also, could you add some docs here to make this a bit more discoverable for users? |
…nsible#1804) Modified the db-migration job template to use `task_*` settings with a fallback to global AWX configurations if not specified.
7e98f78 to
cb3dcc6
Compare
|
@rooftopcellist thank you for the feedback. It makes sense for this migration job to utilize the task_* settings. I decided to implement this the same way the Task pods have been configured here so that we get the benefit of falling back to the global node assignment settings Also updated the docs! |
rooftopcellist
left a comment
There was a problem hiding this comment.
I tested this out on my cluster and it works as expected as far as I can tell. No errors on fresh install either.
@ranvit Thanks for the PR!
|
@rooftopcellist how do you feel about adding the same tolerations/nodeSelector fallback on the Backup role's db-management pod? I could go through every k8s pod template in the repo and add the same fix |
SUMMARY
As described in #1774, the migration pod has no provisions to add tolerations to it. This PR's solution is to use the postgres pod's toleration/selector on the migration job.
The docs would need to be updated to alert the user about this relationship between postgres and the migration pod
ISSUE TYPE