hostname module: add support for Amazon Linux#5090
Merged
jctanner merged 1 commit intoansible:develfrom Dec 3, 2013
dragon3:hostname_support_amazon_linux
Merged
hostname module: add support for Amazon Linux#5090jctanner merged 1 commit intoansible:develfrom dragon3:hostname_support_amazon_linux
jctanner merged 1 commit intoansible:develfrom
dragon3:hostname_support_amazon_linux
Conversation
|
Can one of the admins verify this patch? |
Contributor
Author
|
@ansible-jenkins Thanks 😄 |
jctanner
added a commit
that referenced
this pull request
Dec 3, 2013
hostname module: add support for Amazon Linux
Contributor
|
@dragon3 thank you! |
Contributor
Author
|
@jctanner Thank you!!! |
Contributor
Author
|
@jctanner Sorry... I made a mistake "os.path.is_file" is mistake... |
Contributor
|
Interesting since the old code was "os.path.is_file". I'll take a look and fix. |
jctanner
added a commit
that referenced
this pull request
Dec 5, 2013
Contributor
|
@dragon3 thanks! |
Contributor
Author
|
@jctanner Thanks! Sorry for my mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for Amazon Linux.
In order to add support for Amazon Linux,
I modified "get_distribution" method of module_utils/basic.py to get "Amazon" distribution,
but I'm not too sure if this is correct.
I found a similar method "get_distribution_facts" on setup module,
but this implementation is very different from module_utils/basic.py's get_distribution.