Allow config to enable native jinja types by jctanner · Pull Request #32738 · ansible/ansible

jctanner · 2017-11-09T14:09:13Z

SUMMARY

Allow config to enable native jinja types

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

templar

ANSIBLE VERSION

2.7

ADDITIONAL INFORMATION

Ties into the jinja 2.10 release feature http://jinja.pocoo.org/docs/2.10/nativetypes/

jctanner · 2017-11-09T14:10:56Z

The initial patch here is pretty hacky, but feedback is very welcome.

dagwieers · 2017-11-09T14:19:37Z

Is this something we would consider for v2.5 ?
And would it be configurable behaviour ?

jctanner · 2017-11-09T14:22:04Z

@dagwieers this is a message I got late last night ...

bcoca [12:47 AM]
@jctanner we need toggle for 'typing' ... off by default in 2.5, on by default in 2.6

The current patch does just that. Off by default.

bcoca · 2017-11-09T14:20:46Z

no need to do this here, AnsibleEnvironment inherits from Environment

bcoca · 2017-11-09T14:21:32Z

I would move the previous:
from jinja2 import Environment
into an 'else/pass' here to make the choice obvious vs the 'masking' of the previous import

ThiefMaster · 2017-11-09T15:13:07Z

Wouldn't getattr(new_context, 'unsafe', False) be cleaner? (no idea about ansible code guidelines, just staw this PR when referenced in the related jinja PR

yep, thanks

cognifloyd

Here, you only swap out the Environment. What about the Template?

How does AnsibleJ2Template compare with NativeTemplate?

AnsibleJ2Template overrides new_context() but NativeTemplate overrides render(). Does Ansible not use render()?

cognifloyd · 2017-11-09T17:46:03Z

What about doing the same with from jinja2.utils import concat as j2_concat?

Done, thanks

Cool. I think you can drop line 41 too.

abadger · 2017-11-10T18:25:44Z

This passed in shippable. The UNSTABLE status is because of an unrelated, transient failure in the opensuse repository for the zypper test. The second test run was fine.

ansibot · 2017-11-15T04:44:22Z

The test ansible-test sanity --test boilerplate [?] failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/template/native_helpers.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/template/native_helpers.py

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/plugins/action/debug.py:53:17: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:32:5: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:33:5: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:34:5: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:38:9: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:42:9: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:43:9: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:44:9: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:45:9: E265 block comment should start with '# '
lib/ansible/template/native_helpers.py:46:9: E265 block comment should start with '# '
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:1:1: E265 block comment should start with '# '
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:5:1: E302 expected 2 blank lines, found 1
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:11:1: E302 expected 2 blank lines, found 1

click here for bot help

ansibot · 2017-11-15T15:13:15Z

The test ansible-test sanity --test boilerplate [?] failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/template/native_helpers.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/template/native_helpers.py

The test ansible-test sanity --test pep8 [?] failed with the following errors:

test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:1:1: E265 block comment should start with '# '
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:5:1: E302 expected 2 blank lines, found 1
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:11:1: E302 expected 2 blank lines, found 1

click here for bot help

ansibot · 2017-11-15T16:10:16Z

The test ansible-test sanity --test pep8 [?] failed with the following errors:

test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:1:1: E265 block comment should start with '# '
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:5:1: E302 expected 2 blank lines, found 1
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:11:1: E302 expected 2 blank lines, found 1

click here for bot help

ansibot · 2017-11-15T17:12:43Z

The test ansible-test sanity --test pep8 [?] failed with the following errors:

test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:1:1: E265 block comment should start with '# '
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:5:1: E302 expected 2 blank lines, found 1
test/integration/targets/jinja2_native_types/filter_plugins/native_plugins.py:11:1: E302 expected 2 blank lines, found 1

click here for bot help

Co-authored-by: Martin Krizek <martin.krizek@gmail.com>

rdtechie · 2018-07-24T05:30:13Z

Forgive me my ignorance. But should this now be solved in devel? I'm using now the devel source from yesterday, but I still cannot get out proper integers. I'm using this playbook to test: https://gist.githubusercontent.com/jctanner/32df50fe270096afc7fe2582e2d21b8c/raw/6fbe189830de4b09d0e322e481fd458031674809/site.yml

abadger · 2018-07-24T06:21:04Z

Did you set the config setting to true?

rdtechie · 2018-07-24T13:23:07Z

@abadger Nope! Works now. 👍 Thanks for the heads up!

jmehnle · 2018-07-24T19:12:37Z

For posterity, the ansible.cfg config setting is jinja2_native in the defaults section.

Ansible cannot template numbers. ``` TACC_API_TIMEOUT: "{{ TACC_API_TIMEOUT }}" ``` Will result in a yaml string. Atmosphere expects this variable to be a yaml number. Ansible fixed this issue in 2.7 ansible/ansible#32738 . Until this is fixed, it is hardcoded.

tobywan · 2019-02-12T13:14:41Z

Alternatively to the config file,
export ANSIBLE_JINJA2_NATIVE=true

jctanner mentioned this pull request Nov 9, 2017

[WIP] force jinja to preserve native types #23943

Closed

ansibot added affects_2.5 This issue/PR affects Ansible v2.5 feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 9, 2017

jctanner changed the title ~~Allow config to enable native jinja types~~ WIP: Allow config to enable native jinja types Nov 9, 2017

jctanner changed the title ~~WIP: Allow config to enable native jinja types~~ [WIP] Allow config to enable native jinja types Nov 9, 2017

ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Nov 9, 2017

bcoca removed the needs_triage Needs a first human triage before being processed. label Nov 9, 2017

bcoca requested changes Nov 9, 2017

View reviewed changes

bcoca added this to the 2.5.0 milestone Nov 9, 2017

ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Nov 9, 2017

bcoca approved these changes Nov 9, 2017

View reviewed changes

jctanner mentioned this pull request Nov 9, 2017

Add support for the Environment to optionally return native types. pallets/jinja#708

Merged

ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Nov 9, 2017

ThiefMaster reviewed Nov 9, 2017

View reviewed changes

cognifloyd mentioned this pull request Nov 9, 2017

Feature: Use Jinja's new NativeEnvironment to get native types instead of strings! StackStorm/st2#3828

Open

cognifloyd reviewed Nov 9, 2017

View reviewed changes

ansible deleted a comment from ansibot Nov 10, 2017

ansibot added plugins/action test This PR relates to tests. labels Nov 15, 2017

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 23, 2017

mkrizek added 6 commits May 30, 2018 17:06

Add add dicts test

ea85f35

Backport upstream native_concat fix

c93050c

Use shorter copyright statement

6bfa9fc

No reason for to_text to fallback to str()

bd68b52

Fix version_added

6c71e5b

Use sameas Jinja2 tests for bool

6b1b4bf

mentos1386 mentioned this pull request May 31, 2018

Fix ec2_ami block_device_mapping volume_size to be int in 2.5 #40938

Merged

mkrizek merged commit a9e53cd into ansible:devel May 31, 2018

This was referenced Jun 20, 2018

Inconsistent variable type preservation #13484

Closed

int is not a number #15249

Closed

jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018

Allow config to enable native jinja types (ansible#32738)

3b31f0c

Co-authored-by: Martin Krizek <martin.krizek@gmail.com>

This was referenced Jun 26, 2018

Jira custom fields not accepting integer variables #29262

Closed

k8s_raw unicode_error when using jinja lookup templating #40185

Closed

yajo mentioned this pull request Jul 26, 2018

docker_service: defined cpus does not get casted into float #30548

Closed

mkrizek mentioned this pull request Aug 17, 2018

Add changelog for Jinja2 native types #44309

Merged

webknjaz mentioned this pull request Sep 1, 2018

Test integration of loop and until options #44927

Merged

cdosborn mentioned this pull request Sep 6, 2018

Add TACC_API_TIMEOUT variable (hardcoded for now) cyverse/clank#277

Merged

2 tasks

vpopescu mentioned this pull request Oct 30, 2018

azure deployment - integers being passed as string #47696

Closed

bcoca mentioned this pull request Nov 1, 2018

int vars mutate to string, unsolicited #38148

Closed

yuwzho mentioned this pull request Apr 11, 2019

set_fact integer assignment #4170

Closed

spantaleev mentioned this pull request Apr 29, 2019

Fix value of nginx-proxy tmpfs size spantaleev/matrix-docker-ansible-deploy#151

Merged

ansible locked and limited conversation to collaborators May 31, 2019

Conversation

jctanner commented Nov 9, 2017 • edited by mkrizek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

Uh oh!

jctanner commented Nov 9, 2017

Uh oh!

dagwieers commented Nov 9, 2017

Uh oh!

jctanner commented Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcoca Nov 9, 2017

Choose a reason for hiding this comment

Uh oh!

bcoca Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ThiefMaster Nov 9, 2017

Choose a reason for hiding this comment

Uh oh!

jctanner Nov 9, 2017

Choose a reason for hiding this comment

Uh oh!

cognifloyd left a comment

Choose a reason for hiding this comment

Uh oh!

cognifloyd Nov 9, 2017

Choose a reason for hiding this comment

Uh oh!

jctanner Nov 9, 2017

Choose a reason for hiding this comment

Uh oh!

cognifloyd Nov 9, 2017

Choose a reason for hiding this comment

Uh oh!

abadger commented Nov 10, 2017

Uh oh!

ansibot commented Nov 15, 2017

Uh oh!

ansibot commented Nov 15, 2017

Uh oh!

ansibot commented Nov 15, 2017

Uh oh!

ansibot commented Nov 15, 2017

Uh oh!

rdtechie commented Jul 24, 2018

Uh oh!

abadger commented Jul 24, 2018

Uh oh!

rdtechie commented Jul 24, 2018

Uh oh!

jmehnle commented Jul 24, 2018

Uh oh!

tobywan commented Feb 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

jctanner commented Nov 9, 2017 •

edited by mkrizek

Loading

jctanner commented Nov 9, 2017 •

edited

Loading

bcoca Nov 9, 2017 •

edited

Loading