fix: handle 0 in ANSI theme color definitions
#5009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the theme color resolution logic where ANSI color value 0 (representing black) was incorrectly treated as falsy and ignored. The fix updates the conditional check from a truthy check to an explicit null check, allowing 0 to be properly recognized as a valid color definition value.
Key Changes:
- Fixed falsy value handling in color definition lookup to support ANSI color value
0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
nice find thx |
spmurrayzzz
pushed a commit
to spmurrayzzz/opencode
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme handling code currently breaks when a color definition uses the ANSI value
0, like:{ "defs": { "black": 0 }, "theme": { "text": "black" } }This PR updates the color definition lookup code to handle 0, which it currently treats as falsey.
Fixes #5010