fix: correct Provider type in chat.params plugin hook #5003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect TypeScript types for the
providerparameter in thechat.paramsplugin hook.Closes #2392
Problem
The
chat.paramshook type usesProviderdirectly, but at runtime the hook receives a wrapper object with the provider info nested under aninfoproperty.Before (incorrect):
Runtime structure:
Solution
Added a new
ProviderContexttype that matches the actual runtime structure and updated thechat.paramshook signature to use it.Changes
ProviderContexttype exportchat.paramshook to useProviderContextinstead ofProviderNotes
auth.loadercallback correctly usesProvider(it receives raw provider info from the database, not the wrapper)Alternative Approach
This PR fixes the types to match the current runtime behavior. An alternative would be to change the runtime to pass
provider.infodirectly (the rawProvider), matching howauth.loaderworks:The alternative would be a cleaner API but would be a breaking runtime change for existing plugins that have worked around the type mismatch by accessing
provider.info.idetc.