fix(app): restore desktop open menu#31993
Open
PatrickLarocque wants to merge 2 commits into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found two related PRs that are directly referenced in your PR:
Both of these are directly acknowledged in your PR description as related work that your PR builds upon or incorporates. Since your PR (31993) is the current PR being checked, it is not a duplicate of itself. The other two PRs are predecessors/related fixes that your PR consolidates. |
208070e to
80433ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29875
Closes #29951
Type of change
What does this PR do?
Restores the desktop session header's Open in control in both titlebar layouts.
Two regressions overlapped:
isDesktopV2from a boolean to a Solid memo, but the<Show>condition still passed the accessor itself. Since the function reference is always truthy, disabling the new layout could not reach the legacy fallback.This PR:
isDesktopV2()so the legacy fallback works again;SessionHeaderV2Actionsusing V2 menu/button primitives;SessionHeader, where its app detection, persisted selection, request state, and callbacks already live, instead of expandingSessionHeaderV2ActionsStatewith pass-through fields;The restored menu supports the native file manager, detected editors/terminals, and Copy path. The underlying
openPathintegration is unchanged.Acknowledgements:
devwith a smaller state boundary.Related reports: #29829, #29867, #31101, #31214, #31458, #31507, and #31878.
How did you verify your code works?
packages/appunit suite: 376 tests passed across 66 files.packages/uisuite: 27 tests passed across 6 files.bun typecheckinpackages/appandpackages/ui.Screenshots / recordings
Before, the V2 session header had no Open-in control:
After, the V2 Open-in menu is restored:
Both screenshots were captured from the local Electron verification for this PR.
Checklist