Skip to content

fix(provider): make small model fallback optional#27405

Merged
kitlangton merged 1 commit into
devfrom
fix/small-model-fallback
May 14, 2026
Merged

fix(provider): make small model fallback optional#27405
kitlangton merged 1 commit into
devfrom
fix/small-model-fallback

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Summary

  • Treat invalid configured small_model as unavailable instead of turning model lookup into a defect.
  • Return auto-selected small models directly from provider state to avoid unnecessary invariant orDie calls.
  • Add coverage for invalid small_model falling back to undefined.

Verification

  • bun test --timeout 30000 test/provider/provider.test.ts
  • git diff --check
  • bun typecheck currently fails on rebased dev in unrelated src/git/index.ts (stdoutTruncated / stderrTruncated missing on RunResult).

@kitlangton kitlangton enabled auto-merge (squash) May 14, 2026 00:36
@kitlangton kitlangton merged commit 9818c9e into dev May 14, 2026
12 checks passed
@kitlangton kitlangton deleted the fix/small-model-fallback branch May 14, 2026 00:44
@dj-nitehawk

Copy link
Copy Markdown

dang! looks like this PR took away my ability to disable the small_model by setting it to an empty string. i do not want session titles auto generated, even if it costs much lower than the regular model.

can you please give back the ability to disable title generation? pleeeeease pretty pleeeeaaaas 🙏🙏🙏

maybe special-case a disable keyword or an empty string " "?

AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
avion23 pushed a commit to avion23/opencode that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants