Skip to content

test: deflake runner cancel test#25021

Merged
kitlangton merged 1 commit into
devfrom
runner-cancel-deflake-void0
Apr 30, 2026
Merged

test: deflake runner cancel test#25021
kitlangton merged 1 commit into
devfrom
runner-cancel-deflake-void0

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Summary

  • Replace the timing sleep in the runner cancel test with a Deferred startup handshake.
  • Complete the Deferred with void 0 so the test only cancels after the work fiber has started.

Tests

  • bun run test test/effect/runner.test.ts
  • bun typecheck

Alternative to #25014.

@kitlangton kitlangton merged commit 6f508d5 into dev Apr 30, 2026
13 checks passed
@kitlangton kitlangton deleted the runner-cancel-deflake-void0 branch April 30, 2026 00:19
isaacfinnegan pushed a commit to isaacfinnegan/whispercode that referenced this pull request Jun 9, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
avion23 pushed a commit to avion23/opencode that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant