Make GroupedMetadata a Protocol #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #38 +/- ##
===========================================
- Coverage 100.00% 95.26% -4.74%
===========================================
Files 1 2 +1
Lines 59 169 +110
Branches 5 48 +43
===========================================
+ Hits 59 161 +102
- Misses 0 7 +7
- Partials 0 1 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adriangb
commented
May 30, 2023
Comment on lines
+174
to
+176
| @property | ||
| def __is_annotated_types_grouped_metadata__(self) -> Literal[True]: | ||
| return True |
Contributor
Author
There was a problem hiding this comment.
Note that this can be implemented as an attribute, the usual "cannot override a property with an attribute" thing type checkers like to complain about doesn't apply to protocol subclasses.
Zac-HD
approved these changes
May 30, 2023
adriangb
added a commit
to adriangb/annotated-types
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36