feat: Support num comments in issue list cmd#853
Merged
ankitpokhrel merged 2 commits intomainfrom May 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for controlling how many comments are shown in both the issue list and issue view commands by wiring a new Comments field through the render path and updating CLI flag handling.
- Introduce
CommentstoDisplayFormatand pass it intoProxyGetIssueandIssueOption - Refactor comment-limiting logic using
min(...) - Add a
--commentsflag with config fallback (num_comments) in bothviewandlistcommands
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/view/issues.go | Add Comments field and use it to filter fetched issue comments |
| internal/view/issue.go | Replace manual limit logic with min and adjust blank fragment |
| internal/cmd/issue/view/view.go | Handle --comments flag with config fallback in view command |
| internal/cmd/issue/list/list.go | Wire --comments flag and config fallback into list command |
Comments suppressed due to low confidence (4)
internal/view/issue.go:29
- The loop
for range nis invalid sincenis an integer; revert to the index-based loop (for i := 0; i < n; i++) or use a slice of lengthnto range over.
for range n {
internal/view/issue.go:389
- Ensure a
minfunction for integers is declared or imported; otherwise revert to the previous inline check (if limit > total { limit = total }).
limit := min(int(i.Options.NumComments), total)
internal/cmd/issue/view/view.go:98
- Verify that a
maxfunction for unsigned integers exists or replace with an explicit check (if numComments < 1 { comments = 1 } else { comments = numComments }).
comments = max(numComments, 1)
internal/cmd/issue/list/list.go:161
- As with the view command, ensure a
maxfunction for unsigned integers is available or use an inline fallback to enforce a minimum of 1.
comments = max(numComments, 1)
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Sep 2, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [ankitpokhrel/jira-cli](https://github.com/ankitpokhrel/jira-cli) | minor | `v1.6.0` -> `v1.7.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>ankitpokhrel/jira-cli (ankitpokhrel/jira-cli)</summary> ### [`v1.7.0`](https://github.com/ankitpokhrel/jira-cli/releases/tag/v1.7.0) [Compare Source](ankitpokhrel/jira-cli@v1.6.0...v1.7.0) This release adds CSV and JSON output support for issue listings and upgrades deprecated endpoints to ensure compatibility with the latest Jira APIs. > \[!IMPORTANT] > > - The [new API](https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-issue-search/#api-rest-api-3-search-jql-get) does not return the total number of entries anymore, so the total issue count is no longer displayed in the search results. > - Consequently, the `startAt` parameter in the new API is unsupported. Therefore, the `from` part of the `--paginate=<from>:<limit>` flag is effectively ignored. Users can still paginate using the maxResults parameter (e.g., --paginate=10). #### 🥷 What's added? - feat: Add option to list issues in raw JSON by [@​evg656e](https://github.com/evg656e) in [#​840](ankitpokhrel/jira-cli#840) - feat: Add releases Subcommand by [@​vkhitrin](https://github.com/vkhitrin) in [#​851](ankitpokhrel/jira-cli#851) - feat: Support num comments in issue list cmd by [@​ankitpokhrel](https://github.com/ankitpokhrel) in [#​853](ankitpokhrel/jira-cli#853) - feat: Support CSV when listing issues by [@​ankitpokhrel](https://github.com/ankitpokhrel) in [#​854](ankitpokhrel/jira-cli#854) - feat: Allow skipping notification on edit by [@​ankitpokhrel](https://github.com/ankitpokhrel) in [#​855](ankitpokhrel/jira-cli#855) - feat: Add command line arg delimiter for custom delimiter instead of tab. by [@​iksi4prs](https://github.com/iksi4prs) in [#​662](ankitpokhrel/jira-cli#662) - feat: Add support for environment variable to specify config file path by [@​aazon](https://github.com/aazon) in [#​858](ankitpokhrel/jira-cli#858) #### 🐞 What's fixed? - fix: usernames can be 2 chars by [@​jontyq](https://github.com/jontyq) in [#​890](ankitpokhrel/jira-cli#890) - fix: Update deprecated endpoint by [@​ankitpokhrel](https://github.com/ankitpokhrel) in [#​892](ankitpokhrel/jira-cli#892) - fix: csv format priority by [@​ciricc](https://github.com/ciricc) in [#​882](ankitpokhrel/jira-cli#882) #### ☕️ Other changes - chore(docs): Add packaging stats to Installation section in README.md by [@​kskarthik](https://github.com/kskarthik) in [#​857](ankitpokhrel/jira-cli#857) #### New Contributors - [@​evg656e](https://github.com/evg656e) made their first contribution in [#​840](ankitpokhrel/jira-cli#840) - [@​vkhitrin](https://github.com/vkhitrin) made their first contribution in [#​851](ankitpokhrel/jira-cli#851) - [@​iksi4prs](https://github.com/iksi4prs) made their first contribution in [#​662](ankitpokhrel/jira-cli#662) - [@​aazon](https://github.com/aazon) made their first contribution in [#​858](ankitpokhrel/jira-cli#858) - [@​jontyq](https://github.com/jontyq) made their first contribution in [#​890](ankitpokhrel/jira-cli#890) - [@​ciricc](https://github.com/ciricc) made their first contribution in [#​882](ankitpokhrel/jira-cli#882) - [@​kskarthik](https://github.com/kskarthik) made their first contribution in [#​857](ankitpokhrel/jira-cli#857) **Full Changelog**: <ankitpokhrel/jira-cli@v1.6.0...v1.7.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45MS4zIiwidXBkYXRlZEluVmVyIjoiNDEuOTEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #511
Resolves #794