Consider Windows Terminal as non-dumb terminal#706
Merged
ankitpokhrel merged 2 commits intoankitpokhrel:mainfrom Mar 16, 2024
beatbrot:respect_wt_session
Merged
Consider Windows Terminal as non-dumb terminal#706ankitpokhrel merged 2 commits intoankitpokhrel:mainfrom beatbrot:respect_wt_session
ankitpokhrel merged 2 commits intoankitpokhrel:mainfrom
beatbrot:respect_wt_session
Conversation
This is in accordance to [this comment](microsoft/terminal#1040 (comment)). As discussed further in the issue, in an ideal world, we wouldn't check "user agents" of terminals one-by-one, but instead would do proper feature probing like described [here](https://github.com/termstandard/colors). But anyway: This is a good first step to enhance Windows support.
Contributor
Author
|
@ankitpokhrel Could you maybe take another look at this? :) Having this fix would really improve my usecase :) |
ankitpokhrel
approved these changes
Mar 16, 2024
Owner
ankitpokhrel
left a comment
There was a problem hiding this comment.
I don't have a windows machine to test this at the moment but looks good. Thanks!
|
Waiting desperately for a release of this :) |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Sep 23, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [ankitpokhrel/jira-cli](https://github.com/ankitpokhrel/jira-cli) | patch | `v1.5.1` -> `v1.5.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>ankitpokhrel/jira-cli (ankitpokhrel/jira-cli)</summary> ### [`v1.5.2`](https://github.com/ankitpokhrel/jira-cli/releases/tag/v1.5.2) [Compare Source](ankitpokhrel/jira-cli@v1.5.1...v1.5.2) #### What's Changed - feat: issue view: Raw response option by [@​mpalahuta](https://github.com/mpalahuta) in ankitpokhrel/jira-cli#720 - feat: Add original estimate option to issue creation by [@​rodcloutier](https://github.com/rodcloutier) in ankitpokhrel/jira-cli#748 - feat: Allow updating parent on edit by [@​ankitpokhrel](https://github.com/ankitpokhrel) in ankitpokhrel/jira-cli#765 - feat: Add cli method for close sprint with supporting jira client … by [@​cworsnup13](https://github.com/cworsnup13) in ankitpokhrel/jira-cli#756 ankitpokhrel/jira-cli#778 - fix: Epic description overridden in no-input mode by [@​ankitpokhrel](https://github.com/ankitpokhrel) in ankitpokhrel/jira-cli#728 - fix: Regression introduced by new OriginalEstimate attribute by [@​fabio42](https://github.com/fabio42) in ankitpokhrel/jira-cli#767 - fix: Consider Windows Terminal as non-dumb terminal by [@​beatbrot](https://github.com/beatbrot) in ankitpokhrel/jira-cli#706 - fix: Improve zsh autocomplete directions by [@​omair-inam](https://github.com/omair-inam) in ankitpokhrel/jira-cli#739 #### New Contributors - [@​mpalahuta](https://github.com/mpalahuta) made their first contribution in ankitpokhrel/jira-cli#720 - [@​omair-inam](https://github.com/omair-inam) made their first contribution in ankitpokhrel/jira-cli#739 - [@​rodcloutier](https://github.com/rodcloutier) made their first contribution in ankitpokhrel/jira-cli#748 - [@​fabio42](https://github.com/fabio42) made their first contribution in ankitpokhrel/jira-cli#767 - [@​cworsnup13](https://github.com/cworsnup13) made their first contribution in ankitpokhrel/jira-cli#756 **Full Changelog**: ankitpokhrel/jira-cli@v1.5.1...v1.5.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in accordance to this comment. As discussed further in the issue, in an ideal world, we wouldn't check "user agents" of terminals one-by-one, but instead would do proper feature probing like described here.
But anyway: This is a good first step to enhance Windows support.