New JS API for bury & suspend card and bury & suspend note and tag card#9245
Merged
mikehardy merged 2 commits intoankidroid:masterfrom Aug 5, 2021
Merged
New JS API for bury & suspend card and bury & suspend note and tag card#9245mikehardy merged 2 commits intoankidroid:masterfrom
mikehardy merged 2 commits intoankidroid:masterfrom
Conversation
mikehardy
requested changes
Jul 17, 2021
Member
mikehardy
left a comment
There was a problem hiding this comment.
I also like this idea a lot but we need to kill the boilerplate on it first thing, before a lot of these go in. I asked for advice there
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java
Outdated
Show resolved
Hide resolved
Member
Author
|
|
mikehardy
approved these changes
Aug 5, 2021
Member
mikehardy
left a comment
There was a problem hiding this comment.
The combined change looks great (that is: implementing the feature, but with @JavascriptInterface
7 tasks
|
Thank you guys so much! |
krmanik
added a commit
to krmanik/Anki-Android
that referenced
this pull request
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request template
Purpose / Description
This continuation of JS API PR to add more functionality and new features to JS API.
Fixes
Fixes #9231
Approach
Added functions to JavaScriptInterface
How Has This Been Tested?
Use following functions for the API
return boolean)return boolean)return boolean)return boolean)void function)Tested on devices and emulator
Learning (optional, can help others)
https://github.com/ankidroid/Anki-Android/wiki/AnkiDroid-Javascript-API
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.
ifstatements)