fix:'NoneType' object is not subscriptable_41_#83
Merged
VikashKothary merged 1 commit intoankicommunity:developfrom Aug 15, 2021
dobefore:NoneType_41_
Merged
fix:'NoneType' object is not subscriptable_41_#83VikashKothary merged 1 commit intoankicommunity:developfrom dobefore:NoneType_41_
VikashKothary merged 1 commit intoankicommunity:developfrom
dobefore:NoneType_41_
Conversation
Member
|
Hi @dobefore, thanks for another great fix. I just want to understand what you mean by "may be inconsistent with previous version". |
Contributor
Author
|
@VikashKothary ,I'm Sorry not think about earlier support. |
MasterNayru
added a commit
to MasterNayru/anki-sync-server
that referenced
this pull request
Jul 19, 2021
Member
|
Let's merge it since it does seem to be a fix. But if there are backward compatibility issues then we can deal with it then. Thanks you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR may be inconsistent with previous version.
@wsgify
def call(self, req):
data = req.POST['data'].file.read()
data = self._decode_data(data, compression)
return value of grave in data is None
so coerce it to default value