Skip to content

Some design/docs additions#11

Merged
anishagg17 merged 1 commit intoanishagg17:textfrom
cchaos:anishagg17-text
Jun 4, 2020
Merged

Some design/docs additions#11
anishagg17 merged 1 commit intoanishagg17:textfrom
cchaos:anishagg17-text

Conversation

@cchaos
Copy link
Copy Markdown

@cchaos cchaos commented Jun 4, 2020

  • Adding prop comments
  • Fixing text contrast
  • Adding snippets
  • Added “NEW” badge

- Adding prop comments
- Fixing text contrast
- Adding snippets
- Added “NEW” badge
@cchaos cchaos mentioned this pull request Jun 4, 2020
9 tasks
@anishagg17 anishagg17 merged commit cbb4308 into anishagg17:text Jun 4, 2020
@cchaos cchaos deleted the anishagg17-text branch June 4, 2020 22:29
anishagg17 added a commit that referenced this pull request Jun 6, 2020
* Added EuiTextDiff component

* fixed sass-linting

* removed unwanted exports

* improved Examples, exported all data from component

* used useMemo

* exported props,used for loop

* allow user to pass components

* yarn.lock updated and deletion component used for example

* used id as key, useMemos combined

* removed disableTimeout prop

* used useMemo for renderedHtml

* Changed slider steps to display result

* tranformed to hook

* removed padding , fontSize controll from euiText

* removed unnecessay props

* used EuiTextDiffProps and removed Funcion def

* used ElementType

* Used diff inside useMemo

* populated text-diff module defination

* Update src-docs/src/views/code/code_example.js

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>

* used _colors and eui_colors_dark.scss for text diff, changed slider props

* valueAppend used

* more detailed timeout description

* insertions/dels are recalculated, improved custom components desc

* console.log removed

* created separate section for text diff

* Update src-docs/src/views/text_diff/text_diff_example.js

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>

* setDel , setIns to zero on value change

* Update src-docs/src/views/text_diff/text_diff_timeout.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src-docs/src/views/text_diff/text_diff_example.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src-docs/src/views/text_diff/text_diff_example.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src-docs/src/views/text_diff/text_diff_custom_components.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/components/code/text_diff.tsx

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src-docs/src/views/text_diff/text_diff_example.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src-docs/src/views/text_diff/text_diff_example.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src-docs/src/views/text_diff/text_diff_example.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src-docs/src/views/text_diff/text_diff_example.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src-docs/src/views/text_diff/text_diff_example.js

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* updated custom-components name, added clasName prop, updated text for examples, removed unnecessary info from examples,moved to utilities

* moved to own folder

* handled props directly

* over rides eslint

* resolved conflicts

* Update .eslintrc.js

* added licence

* used license for all files

* removed default  wraper from

* removed timeout example

* Some design/docs additions (#11)

- Adding prop comments
- Fixing text contrast
- Adding snippets
- Added “NEW” badge

* added test, CL, updated branch

* updated test

* fixed snaps

* snaps

* linting fixed

* Update CHANGELOG.md

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants