Preserve error context in _getSequelizeConnectionManager#348
Merged
animir merged 4 commits into266-support-sequelize-7from Feb 7, 2026
Merged
Preserve error context in _getSequelizeConnectionManager#348animir merged 4 commits into266-support-sequelize-7from
animir merged 4 commits into266-support-sequelize-7from
Conversation
Merged
Co-authored-by: animir <4623196+animir@users.noreply.github.com>
Co-authored-by: animir <4623196+animir@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update implementation based on Sequelize 7 support feedback
Preserve error context in _getSequelizeConnectionManager
Feb 7, 2026
animir
reviewed
Feb 7, 2026
Co-authored-by: animir <4623196+animir@users.noreply.github.com>
animir
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #347 regarding error handling in
_getSequelizeConnectionManager. When accessingconnectionManagerthrows (Sequelize v7+) and no fallback is available, the original error was silently swallowed, making misconfiguration harder to debug.Changes:
this.client.connectionManagerBefore:
After:
This approach preserves the complete error context including the stack trace, making debugging significantly easier when misconfiguration occurs.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.