Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds compatibility for Sequelize v7 by making MySQL/Postgres limiters resilient to sequelize.connectionManager access throwing, with tests covering both the legacy v6 interface and the v7 dialect fallback.
Changes:
- Update MySQL/Postgres Sequelize connection acquisition/release to use a helper that falls back to
dialect.connectionManager. - Add unit tests validating fallback behavior when
connectionManagerthrows, and direct usage for the v6 interface. - Bump package version to
9.1.1.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/RateLimiterPostgres.js | Adds _getSequelizeConnectionManager() and routes Sequelize connection handling through it. |
| lib/RateLimiterMySQL.js | Adds _getSequelizeConnectionManager() and routes Sequelize connection handling through it. |
| test/RateLimiterPostgres.test.js | Adds coverage for Sequelize v7 fallback + v6 direct connectionManager behavior. |
| test/RateLimiterMySQL.test.js | Adds coverage for Sequelize v7 fallback + v6 direct connectionManager behavior. |
| package.json | Version bump to 9.1.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
Co-authored-by: animir <4623196+animir@users.noreply.github.com>
Co-authored-by: animir <4623196+animir@users.noreply.github.com>
Co-authored-by: animir <4623196+animir@users.noreply.github.com>
Co-authored-by: animir <4623196+animir@users.noreply.github.com>
Co-authored-by: animir <4623196+animir@users.noreply.github.com>
Preserve error context in _getSequelizeConnectionManager
Rethrow original error in _getSequelizeConnectionManager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.