This repository was archived by the owner on Nov 21, 2025. It is now read-only.
fix: support to show the tag info in the jsDoc#1904
Merged
atscott merged 1 commit intoangular:mainfrom Oct 9, 2023
Merged
Conversation
96f11a1 to
73f5b2b
Compare
73f5b2b to
29fd08d
Compare
ivanwonder
added a commit
to ivanwonder/angular
that referenced
this pull request
Jul 22, 2023
The Angular VSCode extension will support showing the tags info in this [PR][1], so the language service can return the tags info now. [1]: angular/vscode-ng-language-service#1904
Closed
14 tasks
Collaborator
|
I would have preferred not needing to do the jsdoc=>markdown conversion in the repo but since I don't have another suggestion, I can't defend blocking this bug fix. Maybe it can be updated at some point in the future. |
atscott
pushed a commit
that referenced
this pull request
Oct 9, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/microsoft/vscode/blob/18136ed6ec4bfabc58664c8b656839709ea997e8/extensions/typescript-language-features/src/languageFeatures/util/textRendering.ts
https://github.com/microsoft/vscode/blob/18136ed6ec4bfabc58664c8b656839709ea997e8/extensions/typescript-language-features/src/test/unit/textRendering.test.ts
The code is copied from the VSCode extension. The difference is that the code runs in the server in the Angular extension, and runs in the client in the VSCode extension
Fixes #1902
cc @dylhunn