This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Merged
Conversation
# Conflicts: # packages/schematics/angular/component/index.ts
c8fba38 to
9d8a5e5
Compare
Brocco
approved these changes
May 21, 2018
Contributor
Brocco
left a comment
There was a problem hiding this comment.
FYI, this could be a single feat commit rather than 2 separate commits.
Contributor
Author
|
Sure, you can squash into one |
JLHwung
added a commit
to JLHwung/angular-cli
that referenced
this pull request
May 25, 2018
JLHwung
added a commit
to JLHwung/angular-cli
that referenced
this pull request
May 30, 2018
clydin
pushed a commit
to angular/angular-cli
that referenced
this pull request
May 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
entryComponentsupport on@schematics/angular/component. Fixes angular/angular-cli#7749Motivation
We use
@angular/clito generate some components and then we use a compiler to imperatively load these components by type, therefore we should add the components toentryComponents. While one can copy and paste betweendeclarationsandentryComponents, it will be of convenience to have this switch right inangular-cli.I also do some minor refactors on the
addDeclarationToNgModuledue to duplicated codes.