build: set es2020 in bazel ts_library usages #2084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b46dab to
c662375
Compare
Currently the default `target` for the code compiled with `ts_library` is set through the `ts_library` exposed in `defaults.bzl`, however the code under the `bazel` directory isn't allowed to use `defaults.bzl` which meant that it was defaulting to es2015. These changes add a `defaults.bzl` specific to the `bazel` directory which allows us to maintain the defaults in a single place. This came up due to a breakage in angular/angular#56096.
c662375 to
8757243
Compare
crisbeto
commented
May 27, 2024
| @@ -0,0 +1,21 @@ | |||
| load("@npm//@bazel/concatjs:index.bzl", _ts_library = "ts_library") | |||
Member
Author
There was a problem hiding this comment.
Technically we could've fixed the issue by adding prodmode_target and devmode_target to all the places using ts_library, but I figured that this is a bit more maintainable.
devversion
approved these changes
May 27, 2024
crisbeto
added a commit
to crisbeto/dev-infra
that referenced
this pull request
May 27, 2024
Fixes that the `defaults.bzl` from angular#2084 wasn't included in the npm package.
devversion
pushed a commit
that referenced
this pull request
May 27, 2024
Fixes that the `defaults.bzl` from #2084 wasn't included in the npm package.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default
targetfor the code compiled withts_libraryis set through thets_libraryexposed indefaults.bzl, however the code under thebazeldirectory isn't allowed to usedefaults.bzlwhich meant that it was defaulting to es2015.These changes add a
defaults.bzlspecific to thebazeldirectory which allows us to maintain the defaults in a single place.This came up due to a breakage in angular/angular#56096.