Skip to content

fix(material/table): style no data row properly#31895

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:22349/no-data-row-styling
Sep 22, 2025
Merged

fix(material/table): style no data row properly#31895
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:22349/no-data-row-styling

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Sep 19, 2025

The "no data" row in the table goes through a different creation flow than the regular table rows which means that it can't get its CSS classes and ends up being unstyled.

These changes add some logic to apply the appropriate classes.

Fixes #22349.

@crisbeto crisbeto requested a review from a team as a code owner September 19, 2025 08:43
@crisbeto crisbeto requested review from ok7sai and tjshiu and removed request for a team September 19, 2025 08:43
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 19, 2025
@crisbeto crisbeto force-pushed the 22349/no-data-row-styling branch from 5d95650 to 34c5958 Compare September 19, 2025 13:48
@crisbeto
fix(material/table): style no data row properly
2d1403b 
The "no data" row in the table goes through a different creation flow than the regular table rows which means that it can't get its CSS classes and ends up being unstyled.

These changes add some logic to apply the appropriate classes.

Fixes angular#22349.
@crisbeto crisbeto force-pushed the 22349/no-data-row-styling branch from 34c5958 to 2d1403b Compare September 20, 2025 07:40
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Sep 22, 2025
@crisbeto crisbeto removed the request for review from tjshiu September 22, 2025 14:57
@crisbeto crisbeto merged commit b6d8193 into angular:main Sep 22, 2025
25 checks passed
@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Sep 22, 2025

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Sep 22, 2025
@crisbeto
fix(material/table): style no data row properly (#31895)
65f23c0 
The "no data" row in the table goes through a different creation flow than the regular table rows which means that it can't get its CSS classes and ends up being unstyled.

These changes add some logic to apply the appropriate classes.

Fixes #22349.

(cherry picked from commit b6d8193)
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Oct 23, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ok7sai ok7sai ok7sai approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/table target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(MatTable): *matNoDataRow not properly styling in flex mode

3 participants

@crisbeto @ok7sai @andrewseguin