fix(material/badge): remove badge opacity color mix#31213
Merged
andrewseguin merged 3 commits intoangular:mainfrom May 29, 2025
Merged
fix(material/badge): remove badge opacity color mix#31213andrewseguin merged 3 commits intoangular:mainfrom
andrewseguin merged 3 commits intoangular:mainfrom
Conversation
crisbeto
approved these changes
May 24, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches M3 experience where disabled badges just include an opacity.
The intent here was to make a disabled badge look better on a disabled button by making it be opaque, but the mix makes it more difficult to use system colors. This also has to make an assumption about the background of the disabled element's container, which is not easily determined anyways. In this case, the button is more likely on a "surface" color anyways, since background is mostly used in other rare situations.
Note also that the M2/M3 spec does not consider disabled badges.
If it seems that this is a common enough UI problem, perhaps we can come up with a new system token about an opaque disabled color without the use of opacity