Use exhaustive checkNoChanges by default#31069
Merged
mmalerba merged 1 commit intoangular:mainfrom May 13, 2025
Merged
Conversation
When components use `OnPush`, they prevent `ExpressionHasChanged...` from being thrown when it should (angular/angular#45612). The exhaustive option ignores dirty flags and traverses the entire view tree checking for changes. This commit configures component tests to do this by default and opts out any tests with existing issues.
mmalerba
approved these changes
May 9, 2025
Contributor
|
@atscott can you run |
Contributor
Author
|
@mmalerba I've dropped the second commit now so it's a test-only change that won't need a presubmit |
mmalerba
pushed a commit
that referenced
this pull request
May 13, 2025
…ult (#31069) When components use `OnPush`, they prevent `ExpressionHasChanged...` from being thrown when it should (angular/angular#45612). The exhaustive option ignores dirty flags and traverses the entire view tree checking for changes. This commit configures component tests to do this by default and opts out any tests with existing issues. (cherry picked from commit 839dfba)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When components use
OnPush, they preventExpressionHasChanged...from being thrown when it should (angular/angular#45612).
The exhaustive option ignores dirty
flags and traverses the entire view tree checking for changes. This
commit configures component tests to do this by default and opts out any
tests with existing issues.
This also includes a commit to show one of the issues that surfaced along with the fix