feat(cdk-experimental/radio): create radio group and button directives#31050
feat(cdk-experimental/radio): create radio group and button directives#31050wagnermaciel merged 10 commits intoangular:mainfrom
Conversation
5f65d22 to
ef789fd
Compare
|
@josephperrott I've added you to check the license of a new dependency. The |
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Manually verified license which is the Mozilla Public License 2.0, which is an approved license for us.
6029611 to
362270f
Compare
362270f to
e40b4f2
Compare
| reverse: (value: V) => T; | ||
| }, | ||
| ) { | ||
| const mappedSignal = linkedSignal(() => operations.transform(originalSignal())); |
There was a problem hiding this comment.
wouldn't alex's suggestion using computed here make more sense? that would avoid needing to manually set both signals
There was a problem hiding this comment.
I thought that recommendation was for something that the FW would roll out. Specifically, the use of the SIGNAL api in the components repo. Trying to reference SIGNAL from the components repo auto-completes the import to @angular/core/graph.d-BcIOep_B which seemed like a red flag to me
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.