fix(cdk/dialog): avoid setting aria-hidden before focus has moved#31030
Merged
crisbeto merged 1 commit intoangular:mainfrom May 6, 2025
Merged
fix(cdk/dialog): avoid setting aria-hidden before focus has moved#31030crisbeto merged 1 commit intoangular:mainfrom
crisbeto merged 1 commit intoangular:mainfrom
Conversation
7bb6c91 to
aedc30f
Compare
The dialog moves focus in an `afterRender`, because it needs to give the content some time to be rendered. This is problematic with some relatively recent behavior in Chrome where the `aria-hidden` gets blocked and a warning is logged if it contains the focused element. These changes add a way for the container to indicate when it's done moving focus and use the new API to apply the `aria-hidden`. Fixes angular#30187.
aedc30f to
f930aaf
Compare
devversion
approved these changes
May 6, 2025
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 6, 2025
…gular#31030) The dialog moves focus in an `afterRender`, because it needs to give the content some time to be rendered. This is problematic with some relatively recent behavior in Chrome where the `aria-hidden` gets blocked and a warning is logged if it contains the focused element. These changes add a way for the container to indicate when it's done moving focus and use the new API to apply the `aria-hidden`. Fixes angular#30187.
crisbeto
added a commit
that referenced
this pull request
May 6, 2025
…1030) (#31036) The dialog moves focus in an `afterRender`, because it needs to give the content some time to be rendered. This is problematic with some relatively recent behavior in Chrome where the `aria-hidden` gets blocked and a warning is logged if it contains the focused element. These changes add a way for the container to indicate when it's done moving focus and use the new API to apply the `aria-hidden`. Fixes #30187.
wildcardalice
pushed a commit
to wildcardalice/components
that referenced
this pull request
May 12, 2025
…gular#31030) The dialog moves focus in an `afterRender`, because it needs to give the content some time to be rendered. This is problematic with some relatively recent behavior in Chrome where the `aria-hidden` gets blocked and a warning is logged if it contains the focused element. These changes add a way for the container to indicate when it's done moving focus and use the new API to apply the `aria-hidden`. Fixes angular#30187.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialog moves focus in an
afterRender, because it needs to give the content some time to be rendered. This is problematic with some relatively recent behavior in Chrome where thearia-hiddengets blocked and a warning is logged if it contains the focused element.These changes add a way for the container to indicate when it's done moving focus and use the new API to apply the
aria-hidden.Fixes #30187.