fix(cdk/schematics): support project index file discovery for object-form and default#30967
Merged
crisbeto merged 1 commit intoangular:mainfrom Apr 28, 2025
Merged
Conversation
…form and default The project index file discovery process now supports finding paths for projects that use the object-form of the `index` field and also for projects that do not explicitly specify an index. Starting with v20, the index field will default to `<project_source_root>/index.html` if not present in the build options for the `application` build system.
crisbeto
approved these changes
Apr 28, 2025
Member
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, although I wonder if this shouldn't be a shared utility in the CLI.
wildcardalice
pushed a commit
to wildcardalice/components
that referenced
this pull request
May 12, 2025
…form and default (angular#30967) The project index file discovery process now supports finding paths for projects that use the object-form of the `index` field and also for projects that do not explicitly specify an index. Starting with v20, the index field will default to `<project_source_root>/index.html` if not present in the build options for the `application` build system.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project index file discovery process now supports finding paths for projects that use the object-form of the
indexfield and also for projects that do not explicitly specify an index. Starting with v20, the index field will default to<project_source_root>/index.htmlif not present in the build options for theapplicationbuild system.