Skip to content

fix(material-angular-io): streamline directive and component metadata handling in dgeni#30661

Merged
mmalerba merged 1 commit intoangular:mainfrom
mistrykaran91:fix/section-issue-between-directives-and-component
Apr 4, 2025
Merged

fix(material-angular-io): streamline directive and component metadata handling in dgeni#30661
mmalerba merged 1 commit intoangular:mainfrom
mistrykaran91:fix/section-issue-between-directives-and-component

Conversation

@mistrykaran91
Copy link
Copy Markdown
Contributor

@mistrykaran91 mistrykaran91 commented Mar 19, 2025

Currently, docs is not grouped based on Components and Directives. This fix will separate those two sections.

Fixes #24093

@mistrykaran91 mistrykaran91 requested a review from a team March 19, 2025 17:08
@mistrykaran91 mistrykaran91 mentioned this pull request Mar 19, 2025
Closed
@mistrykaran91 mistrykaran91 requested a review from a team as a code owner March 20, 2025 09:31
@mistrykaran91 mistrykaran91 requested review from crisbeto and wagnermaciel and removed request for a team March 20, 2025 09:31
@angular-robot angular-robot bot added area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project area: cdk/overlay area: material/timepicker area: cdk/tree labels Mar 20, 2025
@mistrykaran91 mistrykaran91 force-pushed the fix/section-issue-between-directives-and-component branch from 55724c1 to 239922b Compare March 20, 2025 09:34
@angular-robot angular-robot bot removed area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project labels Mar 20, 2025
@mistrykaran91 mistrykaran91 force-pushed the fix/section-issue-between-directives-and-component branch 3 times, most recently from dd2f276 to 573efbe Compare March 20, 2025 09:50
@mistrykaran91 mistrykaran91 force-pushed the fix/section-issue-between-directives-and-component branch from 573efbe to 4f56add Compare March 20, 2025 09:57
@mistrykaran91
Copy link
Copy Markdown
Contributor Author

mistrykaran91 commented Mar 20, 2025

Not sure why other labels are added. I just rebased it with the main branch and pushed it. So it might be because of previous changes it added that. Should I another MR by closing this one and branching out from main again ?

josephperrott
josephperrott approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistrykaran91
Copy link
Copy Markdown
Contributor Author

mistrykaran91 commented Mar 22, 2025 •
edited
Loading

@josephperrott, There's one more change in thescss file related to updating the font-size that I have made it.

@mistrykaran91
fix(material-angular-io): streamline directive and component metadata…
8cd3206 
… handling in dgeni

Currently, docs is not grouped based on Components and Directives. This fix will separate those two sections.

Fixes angular#24093
@mistrykaran91 mistrykaran91 force-pushed the fix/section-issue-between-directives-and-component branch from 379bdf8 to 8cd3206 Compare March 29, 2025 05:29
@mistrykaran91
Copy link
Copy Markdown
Contributor Author

mistrykaran91 commented Mar 29, 2025 •
edited
Loading

@josephperrott @crisbeto, any idea when this can be merged ?

josephperrott
josephperrott approved these changes Mar 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 4, 2025
@mmalerba mmalerba merged commit 3a1a0b3 into angular:main Apr 4, 2025
24 of 25 checks passed
mistrykaran91 added a commit to mistrykaran91/components that referenced this pull request Apr 7, 2025
@mistrykaran91
fix(material-angular-io): streamline directive and component metadata…
e2b64d6 
… handling in dgeni (angular#30661)

Currently, docs is not grouped based on Components and Directives. This fix will separate those two sections.

Fixes angular#24093
@mistrykaran91 mistrykaran91 deleted the fix/section-issue-between-directives-and-component branch April 15, 2025 13:16
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented May 16, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto was automatically assigned from angular/components-googlers

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel wagnermaciel was automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material.angular.io

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs-bug(icon): MatIcon appears in the Directives section

3 participants

@mistrykaran91 @josephperrott @mmalerba