Skip to content

fix(material/slide-toggle): remove divs from button#29485

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:slide-toggle-button-div
Jul 25, 2024
Merged

fix(material/slide-toggle): remove divs from button#29485
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:slide-toggle-button-div

Conversation

@crisbeto
Copy link
Copy Markdown
Member

Replaces div nodes inside the button with span since the former trigger some automated checkers.

Fixes #29484.

Replaces `div` nodes inside the `button` with `span` since the former trigger some automated checkers.

Fixes angular#29484.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 25, 2024
@crisbeto crisbeto requested a review from a team as a code owner July 25, 2024 08:51
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team July 25, 2024 08:51
@crisbeto crisbeto removed the request for review from andrewseguin July 25, 2024 20:50
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 25, 2024
@crisbeto crisbeto merged commit 1aa8512 into angular:main Jul 25, 2024
crisbeto added a commit that referenced this pull request Jul 25, 2024
Replaces `div` nodes inside the `button` with `span` since the former trigger some automated checkers.

Fixes #29484.

(cherry picked from commit 1aa8512)
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(slide-toggle): The button element contains div elements

2 participants