build: docs incorrectly outputting function parameters with object literal type#29471
Merged
crisbeto merged 1 commit intoangular:mainfrom Jul 23, 2024
Merged
build: docs incorrectly outputting function parameters with object literal type#29471crisbeto merged 1 commit intoangular:mainfrom
crisbeto merged 1 commit intoangular:mainfrom
Conversation
…teral type We were extracting the type of a function parameter by splitting on `:` and taking the second item. The problem is that if the type is an object literal, it'll have more than one colon in its text. These changes fix the issue by only looking for the first colon and extracting the name based on it.
devversion
approved these changes
Jul 23, 2024
crisbeto
added a commit
that referenced
this pull request
Jul 23, 2024
…teral type (#29471) We were extracting the type of a function parameter by splitting on `:` and taking the second item. The problem is that if the type is an object literal, it'll have more than one colon in its text. These changes fix the issue by only looking for the first colon and extracting the name based on it. (cherry picked from commit 315ebf1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were extracting the type of a function parameter by splitting on
:and taking the second item. The problem is that if the type is an object literal, it'll have more than one colon in its text.These changes fix the issue by only looking for the first colon and extracting the name based on it.