Skip to content

fix(material/snack-bar): prevent override of snack bar action button color#27511

Merged
mmalerba merged 1 commit into
angular:mainfrom
json-derulo:bugfix/snack-bar-button-color-overridden
Nov 12, 2024
Merged

fix(material/snack-bar): prevent override of snack bar action button color#27511
mmalerba merged 1 commit into
angular:mainfrom
json-derulo:bugfix/snack-bar-button-color-overridden

Conversation

@json-derulo

@json-derulo json-derulo commented Jul 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Prevents the color (if specified) of the snack bar action button from being overridden to the accent color, when using the matSnackBarAction directive.

Closes #27328

@wagnermaciel wagnermaciel requested a review from mmalerba July 26, 2023 14:27
@mmalerba mmalerba requested a review from crisbeto July 27, 2023 18:38
@mmalerba

mmalerba commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

@crisbeto can you confirm if this was intended to only apply to unthemed buttons

crisbeto
crisbeto approved these changes Jul 27, 2023
View reviewed changes

@crisbeto crisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me that we don't override the color the user explicitly opted into.

@vmuresanu

vmuresanu commented Nov 10, 2023

Copy link
Copy Markdown

Just stumbled upon this issue. @mmalerba @crisbeto any chance this PR is merged so that user can override the --mat-mdc-snack-bar-button-color variable?

@vmuresanu vmuresanu mentioned this pull request Nov 10, 2023
Closed
1 task
@e-karlsson

e-karlsson commented Feb 7, 2024

Copy link
Copy Markdown

Any chance this will be merged soon? @crisbeto
Or if there is any other way to get it fixed to override the color of action button in snackbar

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 14, 2024
@json-derulo json-derulo force-pushed the bugfix/snack-bar-button-color-overridden branch from 87d23cf to fa2cb05 Compare July 3, 2024 14:47
@json-derulo json-derulo requested a review from a team as a code owner July 3, 2024 14:47
@json-derulo

json-derulo commented Jul 3, 2024

Copy link
Copy Markdown
Contributor Author

@mmalerba @crisbeto I fixed the merge conflicts, the changes merge cleanly again. Is there something else blocking this PR from being merged?

@mmalerba

mmalerba commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

I think just the Google internal tests. I kicked off a run, lets see how it goes

@mmalerba mmalerba self-assigned this Jul 17, 2024
@mmalerba mmalerba removed the request for review from andrewseguin November 12, 2024 19:35
@mmalerba mmalerba merged commit d0cf8bf into angular:main Nov 12, 2024
mmalerba pushed a commit that referenced this pull request Nov 12, 2024
@json-derulo @mmalerba
fix(material/snack-bar): prevent override of snack bar action button …
bb66db7 
…color (#27511)

Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
(cherry picked from commit d0cf8bf)
mmalerba pushed a commit that referenced this pull request Nov 12, 2024
@json-derulo @mmalerba
fix(material/snack-bar): prevent override of snack bar action button …
aed9094 
…color (#27511)

Co-authored-by: Daniel Kimmich <json-derulo@users.noreply.github.com>
(cherry picked from commit d0cf8bf)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Dec 13, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

+1 more reviewer

@mmalerba mmalerba mmalerba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(snack-bar): action button color not changeable

5 participants

@json-derulo @mmalerba @vmuresanu @e-karlsson @crisbeto