refactor(material/typography): Move define-typography-config under _typography.scss #27195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
approved these changes
May 30, 2023
crisbeto
approved these changes
May 30, 2023
…ypography.scss This never should have been under _all-typography.scss to begin with. _all-typography.scss depends on all of the component themes, which prevents any of the component themes from using this function as it would cause a circular dep. Instead, moving it under _typography.scss where the legacy version lives makes much more sense.
…nder _typography.scss
mmalerba
added a commit
that referenced
this pull request
May 31, 2023
…ypography.scss (#27195) * refactor(material/typography): Move define-typography-config under _typography.scss This never should have been under _all-typography.scss to begin with. _all-typography.scss depends on all of the component themes, which prevents any of the component themes from using this function as it would cause a circular dep. Instead, moving it under _typography.scss where the legacy version lives makes much more sense. * fixup! refactor(material/typography): Move define-typography-config under _typography.scss (cherry picked from commit 3749308)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This never should have been under _all-typography.scss to begin with. _all-typography.scss depends on all of the component themes, which prevents any of the component themes from using this function as it would cause a circular dep. Instead, moving it under _typography.scss where the legacy version lives makes much more sense.