Skip to content

fix(material/schematics): use provider functions in ng add #26920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
angular-robot merged 1 commit into from
Apr 13, 2023
Merged

fix(material/schematics): use provider functions in ng add #26920

angular-robot merged 1 commit into from
Apr 13, 2023

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 13, 2023

Switches to generating provideAnimations and provideNoopAnimations instead of importProvidersFrom(BrowserAnimationsModule) in ng add.

@crisbeto
fix(material/schematics): use provider functions in ng add
7658440 
Switches to generating `provideAnimations` and `provideNoopAnimations` instead of `importProvidersFrom(BrowserAnimationsModule)` in `ng add`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Apr 13, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 13, 2023
@angular-robot angular-robot bot merged commit d69a6f5 into angular:main Apr 13, 2023
angular-robot bot pushed a commit that referenced this pull request Apr 13, 2023
@crisbeto
fix(material/schematics): use provider functions in ng add (#26920)
22410a9 
Switches to generating `provideAnimations` and `provideNoopAnimations` instead of `importProvidersFrom(BrowserAnimationsModule)` in `ng add`.

(cherry picked from commit d69a6f5)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 6, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @devversion