Skip to content

fix(material/datepicker): fix date picker shortcuts#25951

Merged
mmalerba merged 2 commits intoangular:mainfrom
sasidharansd:my-fix-branch
Nov 29, 2022
Merged

fix(material/datepicker): fix date picker shortcuts#25951
mmalerba merged 2 commits intoangular:mainfrom
sasidharansd:my-fix-branch

Conversation

@sasidharansd
Copy link
Copy Markdown
Contributor

@sasidharansd sasidharansd commented Nov 10, 2022

Fixes a bug in the Angular Material datepicker component where the datepicker should open/close only on alt+down and alt+up respectively but using shift + ctrl + alt + down or ctrl + alt + down the datepicker was opening, and same happens for closing the date picker added a condition to check if ctrl, shift or meta keys are present and if it is present restricting datepicker to not to open/close.

Fixes #25868

mmalerba
mmalerba approved these changes Nov 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Nov 11, 2022
@mmalerba
Copy link
Copy Markdown
Contributor

mmalerba commented Nov 11, 2022

@sasidharansd can you run yarn bazel run //tools/public_api_guard:cdk/keycodes.md_api.accept to approve the API change?

@sasidharansd
fix(material/datepicker): fix date picker shortcuts
0010f86 
Fixes a bug in the Angular Material `datepicker` component where the
datepicker should open/close only on alt+down and alt+up respectively
but using shift + ctrl + alt + down or ctrl + alt + down the datepicker
was opening, and same happens for closing the date picker added a
condition to check if ctrl, shift or meta keys are present and if it
is present restricting datepicker to not to open/close.

Fixes angular#25868
@sasidharansd
fix(material/datepicker): fix date picker shortcuts 
0524c05 
Fixes a bug in the Angular Material datepicker component where the datepicker should open/close only on alt+down and alt+up respectively but using shift + ctrl + alt + down or ctrl + alt + down the datepicker was opening, and same happens for closing the date picker added a condition to check if ctrl, shift or meta keys are present and if it is present restricting datepicker to not to open/close.

Fixes angular#25868
@sasidharansd
Copy link
Copy Markdown
Contributor Author

sasidharansd commented Nov 12, 2022

@sasidharansd can you run yarn bazel run //tools/public_api_guard:cdk/keycodes.md_api.accept to approve the API change?

Done, I have ran the cmd and updated the PR.

@sasidharansd
Copy link
Copy Markdown
Contributor Author

sasidharansd commented Nov 12, 2022

@mmalerba This is my first time contributing. Could you please help me to know. is there anything that I should be doing more or is everything done from my end and I should be wait for the pr to be reviewed ?

@mmalerba
Copy link
Copy Markdown
Contributor

mmalerba commented Nov 28, 2022

There is nothing to be done on your end for the moment. We need to run this against Google's internal tests and make sure everything passes. We'll reach out if there are issues

@mmalerba mmalerba self-assigned this Nov 29, 2022
@mmalerba mmalerba merged commit d02cc68 into angular:main Nov 29, 2022
@mmalerba mmalerba assigned mmalerba and unassigned mmalerba Nov 29, 2022
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Dec 30, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@zarend zarend Awaiting requested review from zarend

1 more reviewer

@mmalerba mmalerba mmalerba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(DatePicker): Fix shortcut to open datepicker

2 participants

@sasidharansd @mmalerba