Skip to content

build: speed up TS compilations and type bundling by removing locale files#24995

Merged
devversion merged 1 commit intoangular:mainfrom
devversion:speed-up-ts-compilations-common-locales
May 30, 2022
Merged

build: speed up TS compilations and type bundling by removing locale files#24995
devversion merged 1 commit intoangular:mainfrom
devversion:speed-up-ts-compilations-common-locales

Conversation

@devversion
Copy link
Member

Removing the locale files will help us reduce Bazel action inputs and
therefore speed up compilations/type bundling because the bazel sandbox
would not need as much files to be sandboxed/symlinked.

More info can be found here: angular/angular#46187

cc. @mmalerba (here as well -- along with the actual PR fix in Angular Bazel)

…files

Removing the locale files will help us reduce Bazel action inputs and
therefore speed up compilations/type bundling because the bazel sandbox
would not need as much files to be sandboxed/symlinked.

More info can be found here: angular/angular#46187
@devversion devversion requested review from a team and crisbeto May 30, 2022 13:47
@devversion devversion added merge safe target: rc This PR is targeted for the next release-candidate labels May 30, 2022
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label May 30, 2022
@devversion devversion merged commit 988faa6 into angular:main May 30, 2022
@devversion devversion deleted the speed-up-ts-compilations-common-locales branch May 30, 2022 14:38
devversion added a commit that referenced this pull request May 30, 2022
…files (#24995)

Removing the locale files will help us reduce Bazel action inputs and
therefore speed up compilations/type bundling because the bazel sandbox
would not need as much files to be sandboxed/symlinked.

More info can be found here: angular/angular#46187

(cherry picked from commit 988faa6)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants