refactor: use light-weight token for form-field in range-picker input#19643
Merged
devversion merged 2 commits intoangular:lightweight-token-optimizationsfrom Jun 17, 2020
Merged
Conversation
b7d9b8b to
bdf0ce2
Compare
The date range picker could be used outside the `MatFormField` component in practice. Right now though, the date-picker input always has a hard-reference on the `MatFormField` component, causing it to be retained. This would be the same in View Engine, but with Ivy this signifies a larger size issue as factories/definitions are directly attached to the component. To allow for better tree-shaking / optimizations, we use the form-field light-weight injection token, so that the date range picker can be used outside of a form-field with minimal cost. Related to: angular#19576.
bdf0ce2 to
bd25e46
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The date range picker could be used outside the
MatFormFieldcomponent in practice. Right now though, the date-picker input
always has a hard-reference on the
MatFormFieldcomponent, causingit to be retained. This would be the same in View Engine, but with
Ivy this signifies a larger size issue as factories/definitions are
directly attached to the component.
To allow for better tree-shaking / optimizations, we use the form-field
light-weight injection token, so that the date range picker can be used
outside of a form-field with minimal cost.
Related to: #19576.