chore: fix inherited host binding issue with sidenav#15898
Merged
mmalerba merged 2 commits intoangular:ivy-2019from Apr 24, 2019
matsko:fix_inherited_host_binding_ivy
Merged
chore: fix inherited host binding issue with sidenav#15898mmalerba merged 2 commits intoangular:ivy-2019from matsko:fix_inherited_host_binding_ivy
mmalerba merged 2 commits intoangular:ivy-2019from
matsko:fix_inherited_host_binding_ivy
Conversation
Due to the inheritance changes present in the Ivy refactor, animation host bindings are being inherited into a the SideNav sub component unexpectedly. This patch ensures that SideNav uses the same animation binding as does its super class.
16 tasks
crisbeto
pushed a commit
to crisbeto/material2
that referenced
this pull request
Jul 17, 2019
* chore: fix inherited host binding issue with sidenav Due to the inheritance changes present in the Ivy refactor, animation host bindings are being inherited into a the SideNav sub component unexpectedly. This patch ensures that SideNav uses the same animation binding as does its super class. * fixup! chore: fix inherited host binding issue with sidenav
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the inheritance changes present in the Ivy refactor,
animation host bindings are being inherited into a the SideNav
sub component unexpectedly. This patch ensures that SideNav
uses the same animation binding as does its super class.