feat(drag-utils): add utility function for cloning array items from one array to another#13743
Merged
mmalerba merged 5 commits intoangular:masterfrom Oct 25, 2018
Merged
Conversation
…ne array to another creates a utility helper for cloning an array item into the array of the drop container compliments moveItemInArray and transferArrayItem partially closes angular#13100
crisbeto
reviewed
Oct 22, 2018
Member
crisbeto
left a comment
There was a problem hiding this comment.
The package-lock should be removed since we're using Yarn.
src/cdk/drag-drop/drag-utils.ts
Outdated
| * @param currentIndex Index of the item in its current array. | ||
| * @param targetIndex Index at which to insert the item. | ||
| * | ||
| * PR NOTE: I followed the pattern of the other two functions here. It would be simpler and more |
Contributor
Author
There was a problem hiding this comment.
Done, what do you think about the change in implementation the note suggested, passing the array element (currentElement) instead of passing currentIndex and currentArray?
nayfin
commented
Oct 23, 2018
Contributor
Author
nayfin
left a comment
There was a problem hiding this comment.
I made all recommended changes. The only open item is whether to change implementation to pass currentElement instead of currentIndex and currentArray to the function. I'll resubmit and change if requested.
…ne array to another resolves issues surfaced from code review
…ne array to another cuts extra space between parens
crisbeto
reviewed
Oct 23, 2018
mmalerba
pushed a commit
that referenced
this pull request
Oct 26, 2018
…ne array to another (#13743) * feat(drag-utils): add utility function for cloning array items from one array to another creates a utility helper for cloning an array item into the array of the drop container compliments moveItemInArray and transferArrayItem partially closes #13100 * feat(drag-utils): add utility function for cloning array items from one array to another resolves issues surfaced from code review * feat(drag-utils): add utility function for cloning array items from one array to another cuts extra space between parens * removes link in comments, and clarifies function definition as recommended in review * resolves nits
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
…ne array to another (angular#13743) * feat(drag-utils): add utility function for cloning array items from one array to another creates a utility helper for cloning an array item into the array of the drop container compliments moveItemInArray and transferArrayItem partially closes angular#13100 * feat(drag-utils): add utility function for cloning array items from one array to another resolves issues surfaced from code review * feat(drag-utils): add utility function for cloning array items from one array to another cuts extra space between parens * removes link in comments, and clarifies function definition as recommended in review * resolves nits
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creates a utility helper for cloning an array item into the array of the drop container
compliments moveItemInArray and transferArrayItem
partially closes #13100 a fix for the UI aspect of this issue will be submitted in the next day or two