Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/components
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b00bf81
Choose a base ref
...
head repository: angular/components
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1f4cac9
Choose a head ref
  • 4 commits
  • 11 files changed
  • 4 contributors

Commits on Apr 14, 2023

  1. fix(material/core): remove tabindex from mat-option (#26917)

    Remove the tabindex attribute added to MatOption components. MatOption
    does not need tabindex because the parent component manages focus by
    setting `aria-activedescendant` attribute. Previously, MatOption set
    tabindex but was also a referenced by aria-activedescendant. This was
    not the correct ARIA semantics. Align closer to ARIA spec by using only
    aria-activedescendant rather than both.
    
    Tabindex="-1" seems to be causing a problem in #26861 where VoiceOver
    with Firefox moves DOM focus from the combobox to the option when
    opening the listbox popup.
    
    Unblocks #26861.
    
    (cherry picked from commit 97410fa)
    zarend committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    af293a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. fix(material/form-field): inconsistent height for non-text inputs (#2…

    …6941)
    
    Fixes that some non-text input variants were taller than the text ones.
    
    Fixes #26915.
    
    (cherry picked from commit 298cbaf)
    crisbeto committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    5623a8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79ee927 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1f4cac9 View commit details
    Browse the repository at this point in the history
Loading