Skip to content

fix(@angular/build): redirect to path with trailing slash for asset directories#27958

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:redirect-asset
Jun 28, 2024
Merged

fix(@angular/build): redirect to path with trailing slash for asset directories#27958
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:redirect-asset

Conversation

@alan-agius4
Copy link
Collaborator

Prior to this commit, accessing a static asset directory without a trailing slash resulted in a 404 error. With this change, we now redirect to the path with a trailing slash, aligning with the behavior of express static.

Closes #27949

…irectories

Prior to this commit, accessing a static asset directory without a trailing slash resulted in a 404 error. With this change, we now redirect to the path with a trailing slash, aligning with the behavior of express static.

Closes angular#27949
@alan-agius4 alan-agius4 requested a review from clydin June 28, 2024 08:58
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 28, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 28, 2024
@alan-agius4 alan-agius4 merged commit 9a1c059 into angular:main Jun 28, 2024
@alan-agius4 alan-agius4 deleted the redirect-asset branch June 28, 2024 13:37
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 18.0.x, 18.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

serve: serving static files using vite differs from the previous builder

2 participants